Skip to content

Conversation

@waldekmastykarz
Copy link
Member

Adds support for SPFx v1.22.0-rc.0. Closes #6974

Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldekmastykarz Amazing work so far 👏
We are on the right track, but I noticed a few things we need to sort out before we proceed.

@Adam-it Adam-it marked this pull request as draft November 23, 2025 00:17
@waldekmastykarz waldekmastykarz marked this pull request as ready for review November 23, 2025 11:11
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldekmastykarz in general I think it is ok. Just wanted to recheck with you one last thing before we merge

So when testing this change, I created a fresh new SPFx 1.22 webpart and in the yo-rc.json I only manually changed the version from 1.22-rc0 to 1.21.0, and then I ran m365 spfx project upgrade --preview.
I expected I would just get a single guide to update the version in the yo-rc file but as a result I got this

image

and this is a bit strange IMO
if we look for the test 1.22-rc0 webpart project package.json
src/m365/spfx/commands/project/test-projects/spfx-1220-rc.0-webpart-react/package.json

  1. It, by default, does not have a dependency to @microsoft/[email protected] so why should we add it now?
  2. also the command outputs to install [email protected] and [email protected] but we do have them but with just ~ before the version. This might be very confusing.
  3. also it suggest to install @microsoft/[email protected] I think this is a bug

could we recheck the above before we proceed

@Adam-it Adam-it marked this pull request as draft November 24, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for SPFx v1.22.0-rc.0

2 participants