-
Notifications
You must be signed in to change notification settings - Fork 366
Adds command spo site accessrequest setting set. Closes #6267
#7010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds command spo site accessrequest setting set. Closes #6267
#7010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new SharePoint Online command spo site accessrequest setting set that allows users to configure access request settings for a specific site. The command supports disabling access requests, routing them to the site owner group, or routing them to a specific email address, with optional custom messaging.
Key Changes
- Adds new command to configure SharePoint site access request settings
- Implements comprehensive validation for mutually exclusive options
- Includes extensive test coverage with 100% code coverage
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/m365/spo/commands/site/site-accessrequest-setting-set.ts |
Main command implementation with validation and API calls to SharePoint REST endpoints |
src/m365/spo/commands/site/site-accessrequest-setting-set.spec.ts |
Comprehensive test suite covering validation scenarios and execution paths |
src/m365/spo/commands.ts |
Adds command constant for registration |
docs/src/config/sidebars.ts |
Updates documentation sidebar navigation |
docs/docs/cmd/spo/site/site-accessrequest-setting-set.mdx |
Command documentation with usage examples and permissions |
.devproxy/api-specs/sharepoint.yaml |
Adds API specifications for the SharePoint REST endpoints used |
| await request.post(requestUseDefault); | ||
|
|
||
| if (message !== undefined) { | ||
|
|
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the empty line between the condition and the verbose logging block to improve code readability and maintain consistency with the rest of the codebase.
|
|
||
|
|
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the trailing empty lines at the end of the file to maintain consistency with project formatting standards.
|
|
||
|
|
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the trailing empty lines at the end of the file to maintain consistency with project formatting standards.
|
|
||
|
|
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the trailing empty lines at the end of the file to maintain consistency with project formatting standards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
|
|
||
|
|
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the trailing blank lines at the end of the file.
|
|
||
|
|
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the trailing blank lines at the end of the file.
|
|
||
|
|
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the trailing blank lines at the end of the file.
Closes #6267