-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command: m365 graph directoryextension add. Closes #6316 #6327
New command: m365 graph directoryextension add. Closes #6316 #6327
Conversation
Thank you, we'll try to review it ASAP! |
fb04f3b
to
f3bd083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MartinM85, sorry for keeping you waiting on this one for so long.
Could you rebase on the latest main, fix the merge conflict that will probably arise and fix the comments?
docs/docs/cmd/graph/directoryextension/directoryextension-add.mdx
Outdated
Show resolved
Hide resolved
docs/docs/cmd/graph/directoryextension/directoryextension-add.mdx
Outdated
Show resolved
Hide resolved
src/m365/graph/commands/directoryextension/directoryextension-add.ts
Outdated
Show resolved
Hide resolved
I like this addition by the way... lets get this in ASAP! |
f3bd083
to
c1957e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it Martin, we should add all CRUD commands for directory extensions (and open extensions) to the CLI. Would be awesome :-)
I'll merge it right after the minor release of tomorrow |
Ok, I will create new issues |
Merged manually, thanks a bunch!! 🚀🚀 |
Closes #6316