Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: m365 graph directoryextension add. Closes #6316 #6327

Closed

Conversation

MartinM85
Copy link
Contributor

Closes #6316

@milanholemans
Copy link
Contributor

Thank you, we'll try to review it ASAP!

@MathijsVerbeeck MathijsVerbeeck self-assigned this Nov 13, 2024
@MartinM85 MartinM85 force-pushed the feature/6316-graph-directoryextension-add branch from fb04f3b to f3bd083 Compare January 7, 2025 09:13
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MartinM85, sorry for keeping you waiting on this one for so long.

Could you rebase on the latest main, fix the merge conflict that will probably arise and fix the comments?

@martinlingstuyl
Copy link
Contributor

I like this addition by the way... lets get this in ASAP!

@martinlingstuyl martinlingstuyl marked this pull request as draft February 26, 2025 21:44
@MartinM85 MartinM85 force-pushed the feature/6316-graph-directoryextension-add branch from f3bd083 to c1957e4 Compare February 27, 2025 07:17
@MartinM85 MartinM85 marked this pull request as ready for review February 27, 2025 07:31
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it Martin, we should add all CRUD commands for directory extensions (and open extensions) to the CLI. Would be awesome :-)

@martinlingstuyl
Copy link
Contributor

I'll merge it right after the minor release of tomorrow

@MartinM85
Copy link
Contributor Author

Love it Martin, we should add all CRUD commands for directory extensions (and open extensions) to the CLI. Would be awesome :-)

Ok, I will create new issues

@martinlingstuyl
Copy link
Contributor

Merged manually, thanks a bunch!! 🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: m365 graph directoryextension add
4 participants