Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 'entra group member remove' command #5844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds 'entra group member remove' command #5844

wants to merge 2 commits into from

Conversation

milanholemans
Copy link
Contributor

@milanholemans milanholemans commented Feb 13, 2024 •
edited
Loading

Closes #5472

  • Made a few small adjustments to entra group user add to align it more with this command.
  • Also introduced a Graph batching interface. Since we use this is multiple commands, it looks handy to have it typed somewhere. Apparently, the graph types dependency doesn't have a type for batch requests.

@milanholemans milanholemans force-pushed the entra-group-user-remove branch from 6dfe178 to a1d6478 Compare February 28, 2024 22:01
waldekmastykarz
waldekmastykarz requested changes Apr 20, 2024
View reviewed changes
src/utils/types.ts Show resolved Hide resolved
src/m365/entra/commands/group/group-user-remove.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/group/group-user-remove.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/group/group-user-remove.spec.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/group/group-user-remove.spec.ts Outdated Show resolved Hide resolved
@waldekmastykarz waldekmastykarz self-assigned this Apr 20, 2024
@waldekmastykarz waldekmastykarz marked this pull request as draft April 20, 2024 13:07
@milanholemans milanholemans force-pushed the entra-group-user-remove branch from a1d6478 to 193de18 Compare April 29, 2024 17:52
@milanholemans milanholemans marked this pull request as ready for review April 29, 2024 17:52
@milanholemans milanholemans marked this pull request as draft May 14, 2024 08:24
@milanholemans milanholemans force-pushed the entra-group-user-remove branch from 193de18 to 0633f4b Compare May 20, 2024 13:30
@milanholemans milanholemans marked this pull request as ready for review May 20, 2024 13:30
@milanholemans milanholemans force-pushed the entra-group-user-remove branch from 0633f4b to bdd4d63 Compare August 5, 2024 22:06
@milanholemans milanholemans force-pushed the entra-group-user-remove branch from bdd4d63 to 27a2dc4 Compare September 28, 2024 23:06
@milanholemans milanholemans changed the title Adds 'entra group user remove' command Adds 'entra group member remove' command Sep 28, 2024
@milanholemans milanholemans force-pushed the entra-group-user-remove branch from 27a2dc4 to 76dfd16 Compare October 19, 2024 10:23
@milanholemans milanholemans marked this pull request as draft November 8, 2024 22:59
@milanholemans milanholemans mentioned this pull request Nov 8, 2024
Closed
3 tasks
@milanholemans
Copy link
Contributor Author

Waiting for this issue to be approved: #6480
I will also add the new options to this command.

@milanholemans milanholemans force-pushed the entra-group-user-remove branch from 76dfd16 to 498e01e Compare January 3, 2025 23:14
@milanholemans milanholemans marked this pull request as ready for review January 3, 2025 23:15
@waldekmastykarz
Copy link
Member

Waiting for this issue to be approved: #6480 I will also add the new options to this command.

Just to check: is this PR on hold because #6480 needs to be done first or is it good to go?

@milanholemans
Copy link
Contributor Author

It's good to go. Just had to check if I should include the new option to remove subgroups or not. Since other maintainers agreed, I added them to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldekmastykarz waldekmastykarz waldekmastykarz requested changes

Assignees

@waldekmastykarz waldekmastykarz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: entra group member remove
2 participants
@milanholemans @waldekmastykarz