Open
Conversation
| "unmet_occupied_load_hours_cooling": 0, | ||
| "building_peak_cooling_load": 25000 | ||
| "building_peak_cooling_load": 25000, | ||
| "baseline_building_performance_energy_cost": 50000 |
Collaborator
There was a problem hiding this comment.
I tested this RPD against the updated 5-1 from Jackson's PR. It turned out that the RPD is invalid due to this key. I believe this key should be under the output key instead of the model_output (similar to the rule_1_2.json). Can you double-check this?
Contributor
Author
There was a problem hiding this comment.
Thanks! I will take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the rule test JSON based on this pull request:
https://github.com/pnnl/ruleset-checking-tool/pull/1852/changes#diff-7e5d12351a30a3e888a174ae05e77ad7e3de53bb62306ccbae018f02ede56340
NOTE: This rule test JSON is NOT part of a spreadsheet given it's unique set of orientations. This is created manually.