Skip to content

Ruletest JSON 6-8 update for Plenum Spaces #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weilixu merged 4 commits into from
Feb 25, 2026
Merged

Ruletest JSON 6-8 update for Plenum Spaces #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bdf022
First cut at 6-8 update to account for plenums
jugonzal07 Feb 6, 2026
c864d22
Updated rule logic/JSON
yunjoonjung-PNNL Feb 13, 2026
2683446
Forgot to add use case h to rule test 6-8
jugonzal07 Feb 14, 2026
ac7b2ac
Rule test 6-8 for 90.1 2019 was updated with an outdated spreadsheet.…
jugonzal07 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 53 additions & 6 deletions rct229/rulesets/ashrae9012019/section6/section6rule8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,33 @@
from rct229.rulesets.ashrae9012019.ruleset_functions.normalize_interior_lighting_schedules import (
normalize_interior_lighting_schedules,
)
from rct229.schema.config import ureg
from rct229.schema.schema_enums import SchemaEnums
from rct229.utils.assertions import getattr_
from rct229.utils.jsonpath_utils import find_all, find_exactly_one_with_field_value
from rct229.utils.pint_utils import ZERO

MANUAL_CHECK_MSG = (
"Lighting schedule in P-RMD including adjusted lighting occupancy sensor reduction factor is "
"higher than that in B-RMD. Verify Additional occupancy sensor control is modeled correctly in "
"P-RMD. "
UNDETERMINED_MSG_SPACE_FUNC = (
"Space is a crawl space, plenum or interstitial space with lighting power in the baseline model. "
"Verify that occupancy sensor control requirements are followed correctly, if applicable."
)
UNDETERMINED_MSG_LTG_SCH = (
"Lighting schedule in the proposed model, including adjusted lighting occupancy sensor reduction, is higher than that in the baseline model. "
"Verify additional occupancy sensor control is modeled correctly in the proposed model."
)
FAIL_MSG = (
"Schedule adjustment may be correct if space includes daylight control modeled by schedule adjustment or "
"individual workstation with lighting controlled by occupancy sensors (TABLE G3.7 Footnote c). "
)

SPACE_FUNCTION = SchemaEnums.schema_enums["SpaceFunctionOptions"]

ACCEPTABLE_SPACE_FUNCTION = [
SPACE_FUNCTION.CRAWL_SPACE,
SPACE_FUNCTION.INTERSTITIAL_SPACE,
SPACE_FUNCTION.PLENUM,
]


class PRM9012019Rule16x33(RuleDefinitionListIndexedBase):
"""Rule 8 of ASHRAE 90.1-2019 Appendix G Section 6 (Lighting)"""
Expand Down Expand Up @@ -120,7 +133,6 @@ def __init__(self):
rmds_used=produce_ruleset_model_description(
USER=False, BASELINE_0=True, PROPOSED=True
),
manual_check_required_msg=MANUAL_CHECK_MSG,
fail_msg=FAIL_MSG,
)

Expand Down Expand Up @@ -154,6 +166,17 @@ def get_calc_vals(self, context, data=None):
building_open_schedule_p,
)

total_space_LPD_b = sum(
[
int_ltg_b.get("power_per_area", 0 * ureg("W/m2"))
for int_ltg_b in find_all(
"$.interior_lighting[*]", space_b
)
]
)

space_function_b = getattr_(space_b, "spaces", "function")

return {
"total_hours_compared": schedule_comparison_result[
"total_hours_compared"
Expand All @@ -164,11 +187,35 @@ def get_calc_vals(self, context, data=None):
"eflh_difference": schedule_comparison_result[
"eflh_difference"
],
"total_space_LPD_b": total_space_LPD_b,
"space_function_b": space_function_b,
}

def manual_check_required(self, context, calc_vals=None, data=None):
space_function_b = calc_vals["space_function_b"]
total_space_LPD_b = calc_vals["total_space_LPD_b"]
eflh_difference = calc_vals["eflh_difference"]
return eflh_difference > 0

return (
space_function_b in ACCEPTABLE_SPACE_FUNCTION
and total_space_LPD_b > 0 * ureg("W/m2")
) or eflh_difference > 0

def get_manual_check_required_msg(
self, context, calc_vals=None, data=None
):
space_function_b = calc_vals["space_function_b"]
total_space_LPD_b = calc_vals["total_space_LPD_b"]

if (
space_function_b in ACCEPTABLE_SPACE_FUNCTION
and total_space_LPD_b > 0 * ureg("W/m2")
):
UNDETERMINED_MSG = UNDETERMINED_MSG_SPACE_FUNC
else:
UNDETERMINED_MSG = UNDETERMINED_MSG_LTG_SCH

return UNDETERMINED_MSG

def rule_check(self, context, calc_vals=None, data=None):
total_hours_compared = calc_vals["total_hours_compared"]
Expand Down
59 changes: 53 additions & 6 deletions rct229/rulesets/ashrae9012022/section6/section6rule8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,33 @@
from rct229.rulesets.ashrae9012022.ruleset_functions.normalize_interior_lighting_schedules import (
normalize_interior_lighting_schedules,
)
from rct229.schema.config import ureg
from rct229.schema.schema_enums import SchemaEnums
from rct229.utils.assertions import getattr_
from rct229.utils.jsonpath_utils import find_all, find_exactly_one_with_field_value
from rct229.utils.pint_utils import ZERO

MANUAL_CHECK_MSG = (
"Lighting schedule in P-RMD including adjusted lighting occupancy sensor reduction factor is "
"higher than that in B-RMD. Verify Additional occupancy sensor control is modeled correctly in "
"P-RMD. "
UNDETERMINED_MSG_SPACE_FUNC = (
"Space is a crawl space, plenum or interstitial space with lighting power in the baseline model. "
"Verify that occupancy sensor control requirements are followed correctly, if applicable."
)
UNDETERMINED_MSG_LTG_SCH = (
"Lighting schedule in the proposed model, including adjusted lighting occupancy sensor reduction, is higher than that in the baseline model. "
"Verify additional occupancy sensor control is modeled correctly in the proposed model."
)
FAIL_MSG = (
"Schedule adjustment may be correct if space includes daylight control modeled by schedule adjustment or "
"individual workstation with lighting controlled by occupancy sensors (TABLE G3.7 Footnote c). "
)

SPACE_FUNCTION = SchemaEnums.schema_enums["SpaceFunctionOptions"]

ACCEPTABLE_SPACE_FUNCTION = [
SPACE_FUNCTION.CRAWL_SPACE,
SPACE_FUNCTION.INTERSTITIAL_SPACE,
SPACE_FUNCTION.PLENUM,
]


class PRM9012022Rule16x33(RuleDefinitionListIndexedBase):
"""Rule 8 of ASHRAE 90.1-2022 Appendix G Section 6 (Lighting)"""
Expand Down Expand Up @@ -120,7 +133,6 @@ def __init__(self):
rmds_used=produce_ruleset_model_description(
USER=False, BASELINE_0=True, PROPOSED=True
),
manual_check_required_msg=MANUAL_CHECK_MSG,
fail_msg=FAIL_MSG,
)

Expand Down Expand Up @@ -154,6 +166,17 @@ def get_calc_vals(self, context, data=None):
building_open_schedule_p,
)

total_space_LPD_b = sum(
[
int_ltg_b.get("power_per_area", 0 * ureg("W/m2"))
for int_ltg_b in find_all(
"$.interior_lighting[*]", space_b
)
]
)

space_function_b = getattr_(space_b, "spaces", "function")

return {
"total_hours_compared": schedule_comparison_result[
"total_hours_compared"
Expand All @@ -164,11 +187,35 @@ def get_calc_vals(self, context, data=None):
"eflh_difference": schedule_comparison_result[
"eflh_difference"
],
"total_space_LPD_b": total_space_LPD_b,
"space_function_b": space_function_b,
}

def manual_check_required(self, context, calc_vals=None, data=None):
space_function_b = calc_vals["space_function_b"]
total_space_LPD_b = calc_vals["total_space_LPD_b"]
eflh_difference = calc_vals["eflh_difference"]
return eflh_difference > 0

return (
space_function_b in ACCEPTABLE_SPACE_FUNCTION
and total_space_LPD_b > 0 * ureg("W/m2")
) or eflh_difference > 0

def get_manual_check_required_msg(
self, context, calc_vals=None, data=None
):
space_function_b = calc_vals["space_function_b"]
total_space_LPD_b = calc_vals["total_space_LPD_b"]

if (
space_function_b in ACCEPTABLE_SPACE_FUNCTION
and total_space_LPD_b > 0 * ureg("W/m2")
):
UNDETERMINED_MSG = UNDETERMINED_MSG_SPACE_FUNC
else:
UNDETERMINED_MSG = UNDETERMINED_MSG_LTG_SCH

return UNDETERMINED_MSG

def rule_check(self, context, calc_vals=None, data=None):
total_hours_compared = calc_vals["total_hours_compared"]
Expand Down
Loading
Loading