Skip to content

RCT/YJ/Copy 2019 to 2022#1913

Merged
weilixu merged 32 commits intodevelopfrom
RCT/YJ/Copy_2019_to_2022
Jan 20, 2026
Merged

RCT/YJ/Copy 2019 to 2022#1913
weilixu merged 32 commits intodevelopfrom
RCT/YJ/Copy_2019_to_2022

Conversation

@yunjoonjung-PNNL
Copy link
Collaborator

No description provided.

@yunjoonjung-PNNL yunjoonjung-PNNL self-assigned this Dec 23, 2025
@yunjoonjung-PNNL yunjoonjung-PNNL marked this pull request as draft December 23, 2025 01:46
@yunjoonjung-PNNL yunjoonjung-PNNL marked this pull request as ready for review December 23, 2025 20:36
from rct229.schema.config import ureg
from rct229.rulesets.ashrae9012019.data import data
from rct229.rulesets.ashrae9012019.data_fns.table_utils import find_osstd_table_entries
from rct229.utils.assertions import assert_
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I deleted any import, it's because it's not used.

@yunjoonjung-PNNL yunjoonjung-PNNL marked this pull request as draft January 6, 2026 20:12
@yunjoonjung-PNNL yunjoonjung-PNNL marked this pull request as ready for review January 7, 2026 21:24
@@ -10,7 +10,7 @@
from rct229.ruletest_engine.ruletest_jsons import get_ruleset_test_sections

TEST_PATH = "ruletest_jsons"

os.environ["RCT_DISABLE_CACHE"] = "1"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the python-app.yml file, the RCT_DISABLE_CACHE is set to "1", and this setting only affects the CI/CD test. To get the same results with it, the setting is needed in the ruletests file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, I have this locally and forgot to push it

@weilixu weilixu merged commit 370e789 into develop Jan 20, 2026
5 checks passed
@weilixu weilixu deleted the RCT/YJ/Copy_2019_to_2022 branch January 20, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments