Skip to content

Highlight Precision Comparison Rounding Issues #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JacksonJ-KC wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Highlight Precision Comparison Rounding Issues #1905

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0da9b65
add test case
JacksonJ-KC Dec 17, 2025
5832981
highlight rounding issue
JacksonJ-KC Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rct229/utils/std_comparisons_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
)

_M2 = ureg("m2")
_TONS = ureg("tons")


def test__std_equal__true_with_units():
Expand Down Expand Up @@ -194,6 +195,10 @@ def test__std_equal_with_precision__10_false_without_units():
assert not std_equal_with_precision(155, 150, 10)


def test__std_equal_with_precision__1_true_with_units():
assert std_equal_with_precision(19.47 * _TONS, 19.52 * _TONS, 1 * _TONS)


def test__std_conservative_outcome__true_with_units_gt():
assert std_conservative_outcome(1.1 * _M2, 1.05 * _M2, operator.gt)

Expand Down
Loading