Merged
Conversation
… into feature/ashrae-9012022
…set-checking-tool into RS-JX-Rule6-11-2022
…leset-checking-tool into RS/JX/Rule5-43-2022
Rule Test 5-43 90.1-2022
…leset-checking-tool into RS/YJ/Rule_22-42_2022
…t-checking-tool into RS/YJ/Rule_22-42_2022
…leset-checking-tool into RS/YJ/Rule_6-10-2022
…leset-checking-tool into RS/YJ/Rule_6-12
…ard descriptions. Test a missed are_scheduled_used_for_occupancy flags and c had it when it shouldn't have. This should be fixed now.
Rule Test JSON 22-42 for ASHARE 90.1-2022
… into merge_develop_ashrae9012022 # Conflicts: # docs/ashrae_90p1_2019/section11/Rule11-5.md # docs/section23/Rule23-6.md
Section5 bugfixes carried forward to 2022
2022 Get ZCC bugfix determination of zone residential spaces
… into merge_develop_ashrae9012022
RS/YJ/Rule_22-42 (2022)
RS/YJ/Rule_22-43 (2022)
…set-checking-tool into merge_develop_ashrae9012022
…not get the right curve set. Also, fixed an issue where 22-44 rule tests had issues with rounding. For now, i have made them exactly right (despite only small rounding errors) in order to get 22-44 out. We will need to address precision equality to fix this correctly.
Rule Test JSON 22-44 for ASHRAE 90.1-2022
RS/YJ/Rule 22-44 (2022)
…set-checking-tool into merge_develop_ashrae9012022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to put it out here, we would have more PRs coming in for this merge.
Including a few in the 90.1 2022.