Skip to content

Rule 6-4 Update: Plenum, crawl-space, interstitial, NONE#1833

Open
claperle wants to merge 7 commits intodevelopfrom
RDS/CML/6-4_Update
Open

Rule 6-4 Update: Plenum, crawl-space, interstitial, NONE#1833
claperle wants to merge 7 commits intodevelopfrom
RDS/CML/6-4_Update

Conversation

@claperle
Copy link
Collaborator

Updated RDS to exclude plenums, interstitial, and crawl spaces.


**Applicability:** All required data elements exist for B_RMR
**Applicability Checks:** None
**Applicability Checks:** Space function is not crawl space, plenum or interstitial space.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip if proposed has no lighting but flag if the proposed does. Same for equipment.

@JacksonJ-KC
Copy link
Collaborator

These updates are on hold until further discussion in the RDS group

@JacksonJ-KC JacksonJ-KC marked this pull request as draft October 15, 2025 12:15
@JacksonJ-KC JacksonJ-KC marked this pull request as ready for review November 18, 2025 14:27
@JacksonJ-KC JacksonJ-KC changed the title RDS 6_4 UPdate RDS 6_4 Update Nov 18, 2025
- Case 1: If space has lighting power and is crawl space, interstitial space, or plenum: UNDETERMINED `if ( total_space_LPD_b > 0 ) AND ( space_function_b in [CRAWL_SPACE, INTERSTITIAL_SPACE, PLENUM] ): UNDETERMINED and raise_warning f"Space function is {space_function_b} and has lighting power modeled. Unable to determine whether this space should be included in the check."`

- Case 1: If space lighting status type is as-designed or as-existing, and lighting space type is not specified: `if ( space_lighting_status_type == "AS-DESIGNED OR AS-EXISTING" ) AND ( NOT space_b.lighting_space_type ): FAIL and raise_warning "P_RMR LIGHTING STATUS TYPE IS AS-DESIGNED OR AS-EXISTING. BUT LIGHTING SPACE TYPE IN B_RMR IS NOT SPECIFIED."`
- Case 1: If space lighting status type is as-designed or as-existing, and lighting space type is not specified: FAIL `if ( space_lighting_status_type == "AS-DESIGNED OR AS-EXISTING" ) AND ( NOT space_b.lighting_space_type ): FAIL and raise_warning "The proposed lighting status is 'AS-DESIGNED OR AS-EXISTING' but the baseline lighting space type was not specified."`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, I think the numbering needs to be revised

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I didn't think our convention was to raise a FAIL when information is not provided, shouldn't this be UNDETERMINED?

Copy link
Collaborator

@JacksonJ-KC JacksonJ-KC Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way it was before updates for plenum/crawl/interstitials but I think I agree. The get_lighting_status_type function will return "AS-DESIGNED OR AS-EXISTING" if the space LPD doesn't match the BAM LPD lookup from Table 9.5.1

@JacksonJ-KC
Copy link
Collaborator

@claperle this one is ready for another review 🤞

Copy link
Collaborator Author

@claperle claperle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacksonJ-KC You can approve this on my behalf. Thanks

Copy link

@supriyagoel supriyagoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@JacksonJ-KC JacksonJ-KC changed the title RDS 6_4 Update Rule 6-4 Update: Plenum, crawl-space, interstitial, NONE Dec 23, 2025
…ed 6-4's case 6 to ensure the lighting system is not-yet-designed by making the proposed system LPD equal to table 9.5.1's requirement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants