Rule 6-4 Update: Plenum, crawl-space, interstitial, NONE#1833
Rule 6-4 Update: Plenum, crawl-space, interstitial, NONE#1833
Conversation
docs/section6/Rule6-4.md
Outdated
|
|
||
| **Applicability:** All required data elements exist for B_RMR | ||
| **Applicability Checks:** None | ||
| **Applicability Checks:** Space function is not crawl space, plenum or interstitial space. |
There was a problem hiding this comment.
Skip if proposed has no lighting but flag if the proposed does. Same for equipment.
|
These updates are on hold until further discussion in the RDS group |
docs/section6/Rule6-4.md
Outdated
| - Case 1: If space has lighting power and is crawl space, interstitial space, or plenum: UNDETERMINED `if ( total_space_LPD_b > 0 ) AND ( space_function_b in [CRAWL_SPACE, INTERSTITIAL_SPACE, PLENUM] ): UNDETERMINED and raise_warning f"Space function is {space_function_b} and has lighting power modeled. Unable to determine whether this space should be included in the check."` | ||
|
|
||
| - Case 1: If space lighting status type is as-designed or as-existing, and lighting space type is not specified: `if ( space_lighting_status_type == "AS-DESIGNED OR AS-EXISTING" ) AND ( NOT space_b.lighting_space_type ): FAIL and raise_warning "P_RMR LIGHTING STATUS TYPE IS AS-DESIGNED OR AS-EXISTING. BUT LIGHTING SPACE TYPE IN B_RMR IS NOT SPECIFIED."` | ||
| - Case 1: If space lighting status type is as-designed or as-existing, and lighting space type is not specified: FAIL `if ( space_lighting_status_type == "AS-DESIGNED OR AS-EXISTING" ) AND ( NOT space_b.lighting_space_type ): FAIL and raise_warning "The proposed lighting status is 'AS-DESIGNED OR AS-EXISTING' but the baseline lighting space type was not specified."` |
There was a problem hiding this comment.
Small comment, I think the numbering needs to be revised
There was a problem hiding this comment.
Also, I didn't think our convention was to raise a FAIL when information is not provided, shouldn't this be UNDETERMINED?
There was a problem hiding this comment.
This is the way it was before updates for plenum/crawl/interstitials but I think I agree. The get_lighting_status_type function will return "AS-DESIGNED OR AS-EXISTING" if the space LPD doesn't match the BAM LPD lookup from Table 9.5.1
|
@claperle this one is ready for another review 🤞 |
claperle
left a comment
There was a problem hiding this comment.
@JacksonJ-KC You can approve this on my behalf. Thanks
…ed 6-4's case 6 to ensure the lighting system is not-yet-designed by making the proposed system LPD equal to table 9.5.1's requirement.
Updated RDS to exclude plenums, interstitial, and crawl spaces.