Update VAVTurndownDuringReheat Untested outcome#59
Update VAVTurndownDuringReheat Untested outcome#59yunjoonjung-PNNL wants to merge 11 commits intodevelopfrom
VAVTurndownDuringReheat Untested outcome#59Conversation
constrain/checklib.py
Outdated
| plt.tight_layout() | ||
| plt.savefig(f"{self.results_folder}/Day_plot_aio.png") | ||
| print() | ||
| if plotday_filtered.size != 0: |
There was a problem hiding this comment.
@leijerry888 The reason why I added this condition is to prevent an error when the size of the plotday_filtered is 0,
There was a problem hiding this comment.
Based on the discussion, we decided not to make updates for plotting in this PR (Interactive plot PR will handle the issue).
|
|
||
| data = [ | ||
| [True, 350, 0], | ||
| [True, 370, 0], |
There was a problem hiding this comment.
seems like this is the only difference from the previous test. Should the error log being asserted in the test?
There was a problem hiding this comment.
Good point.
One thing I don't understand is that when I added the following code at the end of the unit test (line 284), the logobs is empty, which I don't understand. I'll keep this PR for now to take more time to find the reason. This shouldn't impact the testing.
with self.assertLogs() as logobs:
self.assertEqual(
"ERROR:root:Any `V_dot_VAV_max` value shouldn't be zero.",
logobs.output[0],
)
|
@yunjoonjung-PNNL, don't forget to deal with the "Untested" plotting, just replace it with nan. |
I'm a bit confused. What's been done in PR #61 was to replace |
Yes, so that plotting can work without reporting error. |
Should all the |
No need to do that. Let's handle it in the super class plotting functions. If no such unit tests are implemented, could you please implement some plotting unit tests with "Untested" in the results to make sure all plotting functions work? Happy to discuss more :) |
2 participants
No description provided.