update to include subagent source in the context.#57
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e860c17120
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def __call__(self) -> BaseAgent: | ||
| load_tool_plugins() | ||
|
|
||
| chat_model = resolve_chat_model( |
There was a problem hiding this comment.
Removing plugin loading from AgentFactory.__call__ breaks entry-point based default tools for any runtime that builds agents directly (for example scripts/tests that do not go through A2AServerManager, which is now the only place calling load_tool_plugins). In those contexts, tools_config entries for plugin-provided tool types now fail at build time with Unknown tool type from the registry, so previously working custom-tool configurations can no longer start.
Useful? React with 👍 / 👎.
| p.get("text") | ||
| for p in parts | ||
| if p.get("kind") == "text" and p.get("text") | ||
| if p.get("kind") == "text" and p.get("text") and not p.get("text").strip().startswith("**Tool") |
There was a problem hiding this comment.
**
The new startswith("**Tool") guard drops any streamed text fragment that happens to begin with that literal prefix, even when it is legitimate assistant content (for example markdown text like **Tool selection criteria** ...). Because this branch processes normal status text parts, the UI can silently lose chunks and produce incomplete replies; filtering should rely on structured event/type metadata rather than a string prefix.
Useful? React with 👍 / 👎.
1 participant
No description provided.