Add additional warning flags and PNGLIB_FALLTHROUGH #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the ISO C standard has defined how to do this across all compilers and all the compilers I have already support it it should be done in the standard way. Doing it like all the other __attribute settings in pngconf.h might be acceptable in 1.6 but existing systems that recognize /FALLTHROUGH/ and don't support __has_attribute need to be handled. It's moot for 1.8 because I'm about to send a PR to use __has_c_attribute in place of all the current stuff. In particular the current VC support cannot implement https://learn.microsoft.com/en-us/cpp/code-quality/c26819?view=msvc-170 |
|
@jbowler Doubt it was me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.