-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CMake config file that follows CMake conventions #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good overall -- but see my comment about the libpng
vs. PNG
namespace.
I would also like to have one commit per one task, submitted on top of the tree, as a general rule. We are sticking to a linear history, going forward, and we reserve the branches for the time when we fork new libpng versions. Could you please squash all commits, then rebase?
Last, if you could please update scripts/cmake/AUTHORS.md
🙂
4fd8310
to
908dcf9
Compare
I have now changed the PR so that it creates the config files I wanted and does not touch anything else. Ready to merge from my side! 😸 |
@ctruta If you find some time to work on libpng, it would be nice if you could merge this. That way we can use 1.6.44 without a patch once that is tagged. 🙂 |
@ctruta Since I just saw that you are active again, it would be nice if you could merge this ;-) |
My apologies for taking so long, and my appreciations for your patience. This PR is next in line. |
@bebuch Integrated in master, and many thanks. This is super-useful. Please don't mind me for modifying your commit directly, instead of asking you to do it in a review. After so much wait, now a lot of people want me to push a new release, sooner instead of later. I hope that you accept my modification -- BUT if you do have objections, feel free to submit another PR. |
New functionality:
find_package(libpng)
Changed behavior:
libpng
aslibpng::libpng
which follows the CMake convention for exported targets (previous it was justlibpng
)lib/cmake/libpng
instead oflib/libpng
to follow the CMake convention