Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react): make the promise hack explicit for older React versions #3026

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Mar 12, 2025

And rename to React.

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 0:22am

Copy link

codesandbox-ci bot commented Mar 12, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Mar 12, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@3026

commit: b221b5e

Copy link

github-actions bot commented Mar 12, 2025

Size Change: +67 B (+0.07%)

Total Size: 97.5 kB

Filename Size Change
./dist/esm/react.mjs 1.42 kB +25 B (+1.8%)
./dist/react.js 1.44 kB +2 B (+0.14%)
./dist/system/react.development.js 1.59 kB +25 B (+1.6%)
./dist/system/react.production.js 921 B +7 B (+0.77%)
./dist/umd/react.development.js 1.57 kB +4 B (+0.25%)
./dist/umd/react.production.js 1 kB +4 B (+0.4%)
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 932 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.19 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react/utils.mjs 746 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla.mjs 1.11 kB
./dist/esm/vanilla/internals.mjs 3.73 kB
./dist/esm/vanilla/utils.mjs 5.07 kB
./dist/index.js 242 B
./dist/react/utils.js 1.4 kB
./dist/system/babel/plugin-debug-label.development.js 1.1 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.29 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react/utils.development.js 860 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla.development.js 1.19 kB
./dist/system/vanilla.production.js 326 B
./dist/system/vanilla/internals.development.js 3.88 kB
./dist/system/vanilla/internals.production.js 2.36 kB
./dist/system/vanilla/utils.development.js 5.28 kB
./dist/system/vanilla/utils.production.js 3.15 kB
./dist/umd/babel/plugin-debug-label.development.js 1.08 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react/utils.development.js 1.54 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla.development.js 1.81 kB
./dist/umd/vanilla.production.js 378 B
./dist/umd/vanilla/internals.development.js 5.17 kB
./dist/umd/vanilla/internals.production.js 3.2 kB
./dist/umd/vanilla/utils.development.js 6.26 kB
./dist/umd/vanilla/utils.production.js 3.79 kB
./dist/utils.js 247 B
./dist/vanilla.js 1.72 kB
./dist/vanilla/internals.js 5.03 kB
./dist/vanilla/utils.js 6.13 kB

compressed-size-action

Copy link

github-actions bot commented Mar 12, 2025

LiveCodes Preview in LiveCodes

Latest commit: b221b5e
Last updated: Mar 12, 2025 12:21pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/466XN833N

See documentations for usage instructions.

@dai-shi dai-shi changed the title refactor(react): avoid promise hack refactor(react): make the promise hack explicit for older React versions Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant