Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): avoid onCancel hack #3019

Merged
merged 10 commits into from
Mar 10, 2025
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Mar 8, 2025

I didn't like onCancel hack.

  • refactor react/useAtomValue.ts
  • refactor vanilla/internals.ts

Copy link

vercel bot commented Mar 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:36pm

Copy link

codesandbox-ci bot commented Mar 8, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Mar 8, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@3019

commit: b12a3f7

Copy link

github-actions bot commented Mar 8, 2025

Size Change: -358 B (-0.37%)

Total Size: 97.4 kB

Filename Size Change
./dist/esm/react.mjs 1.39 kB -9 B (-0.64%)
./dist/esm/vanilla/internals.mjs 3.73 kB -97 B (-2.53%)
./dist/react.js 1.44 kB -5 B (-0.35%)
./dist/system/react.development.js 1.56 kB +3 B (+0.19%)
./dist/system/react.production.js 914 B +45 B (+5.18%) 🔍
./dist/system/vanilla/internals.development.js 3.88 kB -96 B (-2.42%)
./dist/system/vanilla/internals.production.js 2.36 kB -73 B (-3%)
./dist/umd/react.development.js 1.57 kB +6 B (+0.38%)
./dist/umd/react.production.js 997 B +54 B (+5.73%) 🔍
./dist/umd/vanilla/internals.development.js 5.17 kB -71 B (-1.35%)
./dist/umd/vanilla/internals.production.js 3.2 kB -40 B (-1.23%)
./dist/vanilla/internals.js 5.03 kB -75 B (-1.47%)
ℹ️ View Unchanged
Filename Size
./dist/babel/plugin-debug-label.js 932 B
./dist/babel/plugin-react-refresh.js 1.14 kB
./dist/babel/preset.js 1.41 kB
./dist/esm/babel/plugin-debug-label.mjs 1 kB
./dist/esm/babel/plugin-react-refresh.mjs 1.19 kB
./dist/esm/babel/preset.mjs 1.49 kB
./dist/esm/index.mjs 62 B
./dist/esm/react/utils.mjs 746 B
./dist/esm/utils.mjs 67 B
./dist/esm/vanilla.mjs 1.11 kB
./dist/esm/vanilla/utils.mjs 5.07 kB
./dist/index.js 242 B
./dist/react/utils.js 1.4 kB
./dist/system/babel/plugin-debug-label.development.js 1.1 kB
./dist/system/babel/plugin-debug-label.production.js 775 B
./dist/system/babel/plugin-react-refresh.development.js 1.29 kB
./dist/system/babel/plugin-react-refresh.production.js 928 B
./dist/system/babel/preset.development.js 1.59 kB
./dist/system/babel/preset.production.js 1.14 kB
./dist/system/index.development.js 252 B
./dist/system/index.production.js 183 B
./dist/system/react/utils.development.js 860 B
./dist/system/react/utils.production.js 462 B
./dist/system/utils.development.js 257 B
./dist/system/utils.production.js 187 B
./dist/system/vanilla.development.js 1.19 kB
./dist/system/vanilla.production.js 326 B
./dist/system/vanilla/utils.development.js 5.28 kB
./dist/system/vanilla/utils.production.js 3.15 kB
./dist/umd/babel/plugin-debug-label.development.js 1.08 kB
./dist/umd/babel/plugin-debug-label.production.js 852 B
./dist/umd/babel/plugin-react-refresh.development.js 1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js 1 kB
./dist/umd/babel/preset.development.js 1.54 kB
./dist/umd/babel/preset.production.js 1.22 kB
./dist/umd/index.development.js 383 B
./dist/umd/index.production.js 328 B
./dist/umd/react/utils.development.js 1.54 kB
./dist/umd/react/utils.production.js 1.01 kB
./dist/umd/utils.development.js 399 B
./dist/umd/utils.production.js 342 B
./dist/umd/vanilla.development.js 1.81 kB
./dist/umd/vanilla.production.js 378 B
./dist/umd/vanilla/utils.development.js 6.26 kB
./dist/umd/vanilla/utils.production.js 3.79 kB
./dist/utils.js 247 B
./dist/vanilla.js 1.72 kB
./dist/vanilla/utils.js 6.13 kB

compressed-size-action

Copy link

github-actions bot commented Mar 8, 2025

LiveCodes Preview in LiveCodes

Latest commit: b12a3f7
Last updated: Mar 10, 2025 2:35pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/AXWKUMEHK

See documentations for usage instructions.

@dai-shi dai-shi changed the title wip: refactor: avoid onCancel hack refactor: avoid onCancel hack Mar 8, 2025
@dai-shi dai-shi marked this pull request as ready for review March 8, 2025 15:10
@dai-shi dai-shi added this to the v2.12.2 milestone Mar 10, 2025
@dai-shi dai-shi changed the title refactor: avoid onCancel hack refactor(core): avoid onCancel hack Mar 10, 2025
@dai-shi dai-shi merged commit 6f2ae77 into main Mar 10, 2025
45 checks passed
@dai-shi dai-shi deleted the refactor/avoid-on-cancel-hack branch March 10, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant