Limit ftplugin to buffer and avoid early lua requires #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes ftplugin behaviour to:
them until user command gets invoked
To deduplicate ftplugins, lua's
dofile
is used to load a specificfile that holds all shared commands. This is equivalent to vimscript
standard
source
approach.These make ftplugin portion of this plugin behave like a good neighbor
ftplugin - its changes are buffer local, as it's invoked when a buffer
filetype matches.
Additionally, ftplugins now read global
disable_typescript_tools
variable, returning early if it's set. Not a common behaviour for
ftplugins in general, but a good way to give users fine control over
plugin behaviour nonetheless.
Not tackled is cleanup in case buffer filetype changes without reloading.
I don't think routines for that currently exists, in fact.
Additional housekeeping
ci: use actions/cache@v3 in tests workflow
fix: use non-deprecated iter_matches with all=true
This fixes nightly test failures. This also changes behaviour in complex
scenarios most likely, as instead of matching just the last node, we now
consider all nodes in the match.