[WIP]Optimize dictFind call in db module: genericSetKey #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of overwrite scenario there are 3 calls for dictFind *1st in genericSetKey -> lookupKeyWrite -> dictFind *2nd in dbOverwrite *3rd in removeExpire -> assertWithInfo This change limit dictfind function call to 1
michalbiesek
force-pushed
the
feat-minimize-dict-pmem-redis
branch
from
d3c8f6d to
5d73d7c
Compare
|
Can one of the admins verify this patch? |
PatKamin
added a commit
to PatKamin/redis
that referenced
this pull request
Oct 28, 2022
[5.0.14-devel] Fix make test failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of overwrite scenario there are 3 calls for dictFind
*1st in genericSetKey -> lookupKeyWrite -> dictFind
*2nd in dbOverwrite
*3rd in removeExpire -> assertWithInfo
This change limit dictfind function call to 1
This change is