Fix - Change default font for special letters #20
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| @@ -78,7 +78,7 @@ public function __construct($format = 'A4', $orient = '') | |||
|
|
|||
| $pdf->SetCreator('GLPI'); | |||
| $pdf->SetAuthor('GLPI'); | |||
| $font = 'helvetica'; | |||
| $font = 'dejavusans'; | |||
There was a problem hiding this comment.
Aren't we just moving the problem to another language?
A few lines down (I can't comment on this), $font is overwritten by $_SESSION[‘glpipdffont’]. Where can we change this value? This is probably what's missing.
There was a problem hiding this comment.
I have removed the use of the glpipdffont session variable. Because apart from causing problems when applying fonts that don't take all character styles into account, it's not very useful.
There was a problem hiding this comment.
We have the same code in the core, so I assume that $_SESSION[‘glpipdffont’] was modifiable in the past. I think that's what we need to look into.
There was a problem hiding this comment.
I've checked it's not modified anywhere in the code
There was a problem hiding this comment.
What I mean is that in the core and the plugin, we are trying to use $_SESSION['glpipdffont'], which is never defined.
The fix you're making in the plugin should also be applied in the core, I think.
|
Please update the CHANGELOG and it will be OK for me. |
Checklist before requesting a review
Please delete options that are not relevant.
Description
Screenshots (if appropriate):