Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load logo from Branding when activated #13

Merged
merged 13 commits into from
Feb 24, 2025
Merged

Load logo from Branding when activated #13

merged 13 commits into from
Feb 24, 2025

Conversation

RomainLvr
Copy link

@RomainLvr RomainLvr commented Jan 15, 2025 •
edited
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

image

image

image

@RomainLvr RomainLvr requested review from stonebuzz and Rom1-B January 15, 2025 14:10
@RomainLvr RomainLvr self-assigned this Jan 15, 2025
stonebuzz
stonebuzz requested changes Jan 15, 2025
View reviewed changes
@stonebuzz stonebuzz self-requested a review January 15, 2025 14:53
stonebuzz
stonebuzz requested changes Jan 15, 2025
View reviewed changes
@RomainLvr RomainLvr requested a review from stonebuzz January 15, 2025 16:16
stonebuzz
stonebuzz requested changes Jan 16, 2025
View reviewed changes
@RomainLvr RomainLvr force-pushed the feat/use-branding-logo branch from 59b4c44 to 183bff3 Compare January 16, 2025 09:11
@stonebuzz stonebuzz self-requested a review January 16, 2025 10:02
stonebuzz
stonebuzz requested changes Jan 16, 2025
View reviewed changes
@RomainLvr @stonebuzz
Update CHANGELOG.md
824a353 
Co-authored-by: Stanislas <[email protected]>
@Rom1-B Rom1-B requested a review from stonebuzz February 4, 2025 09:16
stonebuzz
stonebuzz requested changes Feb 4, 2025
View reviewed changes
@stonebuzz
Copy link

after internal discussion :

the Branding logo should not be loaded from the PDF plugin

PDF plugin must set up a HOOK, allowing the Branding plug-in to propose its logo.

You can take inspiration from this to create hook from PDF

https://github.com/pluginsGLPI/treeview/blob/1eb1f01bc74c947475344f6ede6f54032b887691/inc/config.class.php#L441

and this to use it from Branding

https://github.com/pluginsGLPI/genericobject/blob/ac3ece6378b4f050d4f2c2640acc4a395aab46eb/setup.php#L135-L162

@RomainLvr RomainLvr requested a review from stonebuzz February 20, 2025 14:30
Rom1-B
Rom1-B requested changes Feb 21, 2025
View reviewed changes
@RomainLvr RomainLvr requested a review from Rom1-B February 21, 2025 16:54
stonebuzz
stonebuzz requested changes Feb 24, 2025
View reviewed changes
@RomainLvr RomainLvr requested a review from stonebuzz February 24, 2025 08:28
@stonebuzz stonebuzz merged commit 1ed8bcb into pluginsGLPI:main Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

Assignees

@RomainLvr RomainLvr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomainLvr @stonebuzz @Rom1-B