Skip to content

Allow selecting GLPI itemtype when importing mobile devices #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cconard96
Copy link

@cconard96 cconard96 commented Apr 7, 2025

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.

Description

This was a feature that was promised in the early days of this plugin but seems to have been forgotten/accidentally removed when I focused on bringing "smart phone" features to GLPI itself. I am reviving the feature based on a community request on the forum and also to later support custom asset types coming in GLPI 11.

@cconard96 cconard96 force-pushed the enhance/choose_itemtype branch from c1dff13 to 38ea16a Compare April 7, 2025 19:01
@cconard96 cconard96 force-pushed the enhance/choose_itemtype branch from 38ea16a to c1fb717 Compare April 7, 2025 19:02
@cconard96 cconard96 marked this pull request as ready for review April 7, 2025 19:03
@stonebuzz stonebuzz requested review from Rom1-B and stonebuzz and removed request for Rom1-B April 8, 2025 10:16
@stonebuzz stonebuzz added the enhancement New feature or request label Apr 8, 2025
@stonebuzz
Copy link

I will not be able to review or validate this PR at the moment. We have just gained partner access with JAMF, but I still do not have access to the data.

@cconard96
Copy link
Author

I will not be able to review or validate this PR at the moment. We have just gained partner access with JAMF, but I still do not have access to the data.

I saw that the partner access was progressing, but wasn't aware of the status of the Jamf Pro instance access. I am asking the person that asked about it on the forum if they could test this too.

@cconard96 cconard96 marked this pull request as draft April 11, 2025 14:23
@cconard96
Copy link
Author

I have some feedback from the user and I at least still need to adjust the configuration options in this PR. Right now you can select a default Computer/Phone Type for each device type in the plugin options but it doesn't account for multiple possible GLPI asset types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants