Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReversibleRanged support for LogCoord. #673

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

booti386
Copy link
Contributor

This allows to use ChartContext::into_coord_trans() on a chart with a logarithmic axis.

@booti386
Copy link
Contributor Author

@AaronErhardt, just a single ping, so it doesn't get lost in limbo

Copy link
Member

@AaronErhardt AaronErhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for the late review.

@AaronErhardt
Copy link
Member

Wait, actually the CI caught some errors...

@booti386
Copy link
Contributor Author

booti386 commented Mar 7, 2025

Thank you for the review!
Seems like i forgot to commit the hunk at the top of the file... Should be ok now.

Copy link
Member

@AaronErhardt AaronErhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AaronErhardt AaronErhardt merged commit a212c30 into plotters-rs:master Mar 7, 2025
8 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants