style/color: derive serialize & deserialize #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10ne1
force-pushed
the
dev/aratiu/allow-serializing-colors
branch
from
3df125c to
030a21a
Compare
AaronErhardt
requested changes
Nov 12, 2024
10ne1
force-pushed
the
dev/aratiu/allow-serializing-colors
branch
from
030a21a to
5eb2238
Compare
Using serde is useful in production, not just during development, so move it to optional dependencies instead of dev-dependencies. This allows to derive serialize/deserialize for the color structs which are very simple using the default implementation, allowing to pass colors along via serialization channels and formats.
10ne1
force-pushed
the
dev/aratiu/allow-serializing-colors
branch
from
5eb2238 to
7f96558
Compare
|
Hello @AaronErhardt and thank you for your patience! I've updated the PR to make serde an optional dependency while still keeping it enabled in dev-dependencies and added a small documentation blurb for the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using serde is useful in production, not just during development, so move it to optional dependencies instead of dev-dependencies.
This allows to derive serialize/deserialize for the color structs which are very simple using the default implementation, allowing to pass colors along via serialization channels and formats.