-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
switch to ruff #5218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gvwilson
wants to merge
9
commits into
main
Choose a base branch
from
switch-to-ruff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,431
−7,445
Open
switch to ruff #5218
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
eb95abc
feat: convert to uv and ruff
gvwilson 9715f2f
Update tests/test_core/test_graph_objs/test_figure_properties.py
gvwilson 6ebb3ab
Update tests/test_core/test_graph_objs/test_figure_properties.py
gvwilson 652a339
Update tests/test_core/test_graph_objs/test_figure_properties.py
gvwilson ec36462
Update tests/test_core/test_graph_objs/test_figure_properties.py
gvwilson ab2a2c2
Update tests/test_core/test_offline/test_offline.py
gvwilson 2461584
Update tests/test_core/test_offline/test_offline.py
gvwilson b08050c
Update tests/test_plotly_utils/validators/test_string_validator.py
gvwilson e8c2317
Update plotly/io/_orca.py
gvwilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| Thanks for your interest in Plotly.py! | ||
| Thanks for your interest in Plotly.py. | ||
| Before opening an issue, please: | ||
|
|
||
| Before opening an issue, please search for existing and closed issues :) | ||
| - Use the [latest version](https://github.com/plotly/plotly.py/blob/main/CHANGELOG.md) of plotly.py in your report unless not applicable. | ||
| - Search for existing and closed issues. | ||
| - Include a minimal reproducible example with bug reports. | ||
|
|
||
| **Please** accompany bug reports with a reproducible example. Please use the [latest version](https://github.com/plotly/plotly.py/blob/main/CHANGELOG.md) of plotly.py in your report unless not applicable. | ||
|
|
||
| Note that GitHub Issues are meant to be used for bug reports and feature requests only. Implementation or usage questions should be asked on [community.plotly.com](https://community.plotly.com/c/graphing-libraries/python/10) or on Stack Overflow (tagged [`plotly`](https://stackoverflow.com/questions/tagged/plotly)). | ||
| Note that GitHub Issues are meant to be used for bug reports and feature requests. | ||
| Questions about usage should be asked on [community.plotly.com](https://community.plotly.com/c/graphing-libraries/python/10). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,38 @@ | ||
| <!-- | ||
| Please uncomment this block and take a look at this checklist if your PR is making substantial changes to **documentation**/impacts files in the `doc` directory. Check all that apply to your PR, and leave the rest unchecked to discuss with your reviewer! Not all boxes must be checked for every PR :) | ||
| Please uncomment this block and fill in this checklist if your PR makes substantial changes to documentation in the `doc` directory. | ||
| Not all boxes must be checked for every PR: | ||
| check those that apply to your PR and leave the rest unchecked to discuss with your reviewer. | ||
|
|
||
| If your PR modifies code of the `plotly` package, we have a different checklist | ||
| below :-). | ||
| If your PR modifies code of the `plotly` package, we have a different checklist below. | ||
|
|
||
| ### Documentation PR | ||
| ## Documentation PR | ||
|
|
||
| - [ ] I've [seen the `doc/README.md` file](https://github.com/plotly/plotly.py/blob/main/doc/README.md) | ||
| - [ ] This change runs in the current version of Plotly on PyPI and targets the `doc-prod` branch OR it targets the `main` branch | ||
| - [ ] If this PR modifies the first example in a page or adds a new one, it is a `px` example if at all possible | ||
| - [ ] Every new/modified example has a descriptive title and motivating sentence or paragraph | ||
| - [ ] Every new/modified example is independently runnable | ||
| - [ ] Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized | ||
| - [ ] Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible | ||
| - [ ] The random seed is set if using randomly-generated data in new/modified examples | ||
| - [ ] New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets | ||
| - [ ] Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations | ||
| - [ ] Imports are `plotly.graph_objects as go` / `plotly.express as px` / `plotly.io as pio` | ||
| - [ ] Data frames are always called `df` | ||
| - [ ] `fig = <something>` call is high up in each new/modified example (either `px.<something>` or `make_subplots` or `go.Figure`) | ||
| - [ ] Liberal use is made of `fig.add_*` and `fig.update_*` rather than `go.Figure(data=..., layout=...)` in every new/modified example | ||
| - [ ] Specific adders and updaters like `fig.add_shape` and `fig.update_xaxes` are used instead of big `fig.update_layout` calls in every new/modified example | ||
| - [ ] `fig.show()` is at the end of each new/modified example | ||
| - [ ] `plotly.plot()` and `plotly.iplot()` are not used in any new/modified example | ||
| - [ ] Hex codes for colors are not used in any new/modified example in favour of [these nice ones](https://github.com/plotly/plotly.py/issues/2192) | ||
| - [ ] I have seen the [`doc/README.md`](https://github.com/plotly/plotly.py/blob/main/doc/README.md) file. | ||
| - [ ] This change runs in the current version of Plotly on PyPI and targets the `doc-prod` branch OR it targets the `main` branch. | ||
| - [ ] If this PR modifies the first example in a page or adds a new one, it is a `px` example if at all possible. | ||
| - [ ] Every new/modified example has a descriptive title and motivating sentence or paragraph. | ||
| - [ ] Every new/modified example is independently runnable. | ||
| - [ ] Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized. | ||
| - [ ] Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible. | ||
| - [ ] The random seed is set if using randomly-generated data. | ||
| - [ ] New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets. | ||
| - [ ] Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations. | ||
| - [ ] Imports are `plotly.graph_objects as go`, `plotly.express as px`, and/or `plotly.io as pio`. | ||
| - [ ] Data frames are always called `df`. | ||
| - [ ] `fig = <something>` is called high up in each new/modified example (either `px.<something>` or `make_subplots` or `go.Figure`). | ||
| - [ ] Liberal use is made of `fig.add_*` and `fig.update_*` rather than `go.Figure(data=..., layout=...)`. | ||
| - [ ] Specific adders and updaters like `fig.add_shape` and `fig.update_xaxes` are used instead of big `fig.update_layout` calls. | ||
| - [ ] `fig.show()` is at the end of each example. | ||
| - [ ] `plotly.plot()` and `plotly.iplot()` are not used in any example. | ||
| - [ ] Named colors are used instead of hex codes wherever possible. | ||
| - [ ] Code blocks are marked with ````python`. | ||
|
|
||
| ## Code PR | ||
|
|
||
| - [ ] I have read through the [contributing notes](https://github.com/plotly/plotly.py/blob/main/CONTRIBUTING.md) and understand the structure of the package. In particular, if my PR modifies code of `plotly.graph_objects`, my modifications concern the `codegen` files and not generated files. | ||
| - [ ] I have added tests (if submitting a new feature or correcting a bug) or | ||
| modified existing tests. | ||
| - [ ] For a new feature, I have added documentation examples in an existing or | ||
| new tutorial notebook (please see the doc checklist as well). | ||
| - [ ] I have added a CHANGELOG entry if fixing/changing/adding anything substantial. | ||
| - [ ] For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well). | ||
| - [ ] I have read through the [contributing notes](https://github.com/plotly/plotly.py/blob/main/CONTRIBUTING.md) and understand the structure of the package. In particular, if my PR modifies code of `plotly.graph_objects`, my modifications concern the code generator and *not* the generated files. | ||
| - [ ] I have added tests or modified existing tests. | ||
| - [ ] For a new feature, I have added documentation examples (please see the doc checklist as well). | ||
| - [ ] I have added a CHANGELOG entry if changing anything substantial. | ||
| - [ ] For a new feature or a change in behavior, I have updated the relevant docstrings in the code. | ||
|
|
||
| --> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.