-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
refactor validators to remove duplicate files #5214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gvwilson
wants to merge
27
commits into
main
Choose a base branch
from
refactor-validators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2cf19ff
removing old generated validators
bmaranville 1f911b6
write single json instead of python files
bmaranville 930509f
generate validator class instances from json data
bmaranville 3fd1cfd
use validators from ValidatorCache
bmaranville 665595d
use validators from ValidatorCache
bmaranville af43f68
use DataValidator from ValidatorCache
bmaranville 771f918
trace validator should be instance not class of DataValidator
bmaranville 6d905e7
use validators from ValidatorCache
bmaranville 58ab3e1
use template validator from ValidatorCache
bmaranville 44f7a4e
allow overlaying args on derived classes
bmaranville 2507be9
add DataValidator to autogenerated instances provided by ValidatorCac…
bmaranville 5d1ccdb
add DataValidator to autogenerated instances provided by ValidatorCac…
bmaranville 6bd2bb3
add DataValidator to autogenerated instances provided by ValidatorCac…
bmaranville fdaf441
use a copy of the DataValidator in BaseFigure, with local set_uid att…
bmaranville 7baa252
update validator params store
bmaranville 0e913eb
DataValidator is an instance already, and is not callable
bmaranville ba8ec10
use heatmap colorscale validator
bmaranville 2454767
update documentation example to use validator from ValidatorCache
bmaranville c62f6cb
cleanup
bmaranville cb4c504
black formatting
bmaranville 6f777ef
black formatting
bmaranville 6be6f28
revert this file - it is auto-generated
bmaranville 1b99411
cleanup
bmaranville 03d85de
use ValidatorCache for generated Layout validators
bmaranville f8daca4
black formatting
bmaranville 0184bd4
feat: regenerating validators with all recent changes
gvwilson 174e5ff
Merge branch 'main' into refactor-validators
gvwilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this line -- needs to remain the same as what's in
pyproject.toml