fix: Skip base64 conversion for empty arrays (fixes #4919) #4922
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it might be a better solution to just not convert empty arrays to base64. |
marthacryan
approved these changes
Dec 3, 2024
emilykl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4919
The error was caused by trying to take the min/max of an empty array.
The error only shows up when the empty array is typed, and is specifically a 'big int' type (
int64oruint64), because the min/max call only happens in those cases.This PR:
to_typed_array_spec()function to just skip b64 encoding entirely in the case of an empty arrayint64is passed into a figure (goandpx). These tests fail onmasterbut pass on this branch.