fix: pandas DataFrame with non-default Index was resulting in scrambled data in scatter_matrix #4921
+44
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These issue get closed "for free" with the latest Narwhals release, as a result of narwhals-dev/narwhals#1474 having been addressed:
DataFrame
with a scrambled index andcolor
inpx.scatter_matrix()
yields mismatched/null colors #4788color
and non-sorted index #3576Furthermore, it allows for the Plotly codebase to be simplified a bit, as
maybe_reset_index
isn't necessary any more. So, I've:Demo:
Latest stable plotly release:
This branch: