fix: Update legend maxheight calculation logic

src/components/legend/attributes.js

@@ -41,8 +41,9 @@ module.exports = {
             'Sets the max height (in px) of the legend, or max height ratio (reference height * ratio) if less than one.',
             'Default value is: 0.5 for horizontal legends; 1 for vertical legends. The minimum allowed height is 30px.',
             'For a ratio of 0.5, the legend will take up to 50% of the reference height before displaying a scrollbar.',
-            'The reference height is the full layout height except for vertically oriented legends with',
-            'a `yref` of `"paper"`, where the reference height is the plot height.'
+            'The reference height is the full layout height with the following exception: vertically oriented legends with',
+            'a `yref` of `"paper"`, unless the legend is located above/below the plot. In this case, the reference height',
+            'is the plot height.'
         ].join(' ')
     },
     borderwidth: {
@@ -243,7 +244,7 @@ module.exports = {
         values: ['auto', 'top', 'middle', 'bottom'],
         editType: 'legend',
         description: [
-            'Sets the legend\'s vertical position anchor',
+            'Sets the legend\'s vertical position anchor.',
             'This anchor binds the `y` position to the *top*, *middle*',
             'or *bottom* of the legend.',
             'Value *auto* anchors legends at their bottom for `y` values less than or equal to 1/3,',

src/components/legend/defaults.js

@@ -188,7 +188,7 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) {
 
     coerce('xanchor', defaultXAnchor);
     coerce('yanchor', defaultYAnchor);
-    coerce('maxheight', isHorizontal ? 0.5 : 1);
+    coerce('maxheight');
     coerce('valign');
     Lib.noneOrAll(containerIn, containerOut, ['x', 'y']);
 

src/components/legend/draw.js

@@ -769,8 +769,12 @@ function computeLegendDimensions(gd, groups, traces, legendObj) {
     var traceGroupGap = legendObj.tracegroupgap;
     var legendGroupWidths = {};
 
-    var { maxheight, orientation, yref } = legendObj;
-    var heightToBeScaled = orientation === "v" && yref === "paper" ? gs.h : fullLayout.height;
+    const { orientation, yref } = legendObj;
+    let { maxheight } = legendObj;
+    const useFullLayoutHeight = isBelowPlotArea || isAbovePlotArea && !(orientation === "v" && yref === "paper")
+    // Set default maxheight here since it depends on values passed in by user
+    maxheight ||= useFullLayoutHeight ? 0.5 : 1;
+    const heightToBeScaled = useFullLayoutHeight ? fullLayout.height : gs.h;
     legendObj._maxHeight = Math.max(maxheight > 1 ? maxheight : maxheight * heightToBeScaled, 30);
 
     var toggleRectWidth = 0;

tasks/find_locale_strings.js

@@ -28,7 +28,7 @@ function findLocaleStrings() {
             var code = fs.readFileSync(file, 'utf-8');
             var filePartialPath = file.substr(constants.pathToSrc.length);
 
-            falafel(code, {locations: true}, function(node) {
+            falafel(code, { ecmaVersion: 12, locations: true }, function(node) {
                 if(node.type === 'CallExpression' &&
                     (node.callee.name === '_' || node.callee.source() === 'Lib._')
                 ) {

tasks/test_syntax.js

@@ -42,7 +42,7 @@ function assertJasmineSuites() {
             var code = fs.readFileSync(file, 'utf-8');
             var bn = path.basename(file);
 
-            falafel(code, {locations: true}, function(node) {
+            falafel(code, { ecmaVersion: 12, locations: true }, function(node) {
                 var lineInfo = '[line ' + node.loc.start.line + '] :';
 
                 if(node.type === 'Identifier' && BLACK_LIST.indexOf(node.name) !== -1) {
@@ -108,7 +108,7 @@ function assertSrcContents() {
 
             // parse through code string while keeping track of comments
             var comments = [];
-            falafel(code, {onComment: comments, locations: true}, function(node) {
+            falafel(code, { ecmaVersion: 12, locations: true, onComment: comments }, function(node) {
                 // look for .classList
                 if(node.type === 'MemberExpression') {
                     var source = node.source();