Skip to content

adds flag to ExternalWrapper to identify if the component is a temporary insertion #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 3, 2025

Conversation

BSd3v
Copy link
Contributor

@BSd3v BSd3v commented Jun 2, 2025

fixes #3320

This adds a flag to the ExternalWrapper that identifies if the component is temporary as in no dash component owns in and it needs to be removed from the layout store once unmounted.

This defaults to false as these are normally mounted under other dash components.

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good.

@T4rk1n T4rk1n merged commit 0a2176b into plotly:dev Jun 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ExternalWrapper when prop removes from layout when unmounted
2 participants