Show preview image in folder content on hover #6551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
|
@iRohitSingh the implementation looks good on the video. I have a few questions regarding the implementation:
|
ichim-david
reviewed
Jan 4, 2025
| @@ -97,6 +103,8 @@ export const ContentsItemComponent = ({ | |||
| order, | |||
| }) => { | |||
| const intl = useIntl(); | |||
| const previewImageUrl = `${item['@id']}/${item.image_scales?.image?.[0]?.scales?.teaser?.download}`; | |||
There was a problem hiding this comment.
@iRohitSingh this lookup should be added in a new component that can be placed in this file
which is called if the item type is image. Right now you would attempt to check this for everything
even if there is no need for it.
ichim-david
reviewed
Jan 4, 2025
| title={item['Type'] || item['@type']} | ||
| />{' '} | ||
| <span title={item.title}> {item.title}</span> | ||
| {item['@type'] === 'Image' ? ( |
There was a problem hiding this comment.
All of @tisto advice is quite valid, lazy loaded when needed, you don't want to load 100 images if you never even interact with them.
ichim-david
requested changes
Jan 4, 2025
DuaaScripts
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6550
Screen.Recording.2024-12-19.at.7.52.51.PM.mov