Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Size of SelectMenu in SelectWidget. #5863

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix Size of SelectMenu in SelectWidget. #5863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf7b669
Fix the size of Select Menu in SelectWidget to prevent users from hav…
victorchrollo14 Mar 10, 2024
7879674
update SelectWidget.test.jsx.snap to fix tests
victorchrollo14 Mar 10, 2024
4bfeeb0
removed menuPortalTarget and Added maxMenuHeight prop
victorchrollo14 Mar 15, 2024
f2af6ac
Merge remote-tracking branch 'upstream/main' into issue-4058
victorchrollo14 Mar 18, 2024
ef9699b
Merge remote-tracking branch 'upstream/main' into issue-4058
victorchrollo14 Mar 18, 2024
0cf03a3
Merge remote-tracking branch 'upstream/main' into issue-4058
victorchrollo14 Mar 21, 2024
824536d
Merge remote-tracking branch 'upstream/main' into issue-4058
victorchrollo14 Apr 10, 2024
2caf15a
Merge remote-tracking branch 'upstream/main' into issue-4058
victorchrollo14 Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/volto/news/4058.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the size of Select Menu in SelectWidget to prevent users from having to scroll both the main modal and dropdown menu to view the field choices by adding a menuPortalTarget prop. @victorchrollo14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change logs should avoid implementation details, as the code covers that.

Suggested change
Fix the size of Select Menu in SelectWidget to prevent users from having to scroll both the main modal and dropdown menu to view the field choices by adding a menuPortalTarget prop. @victorchrollo14
In a modal with a `SelectWidget`, the parent modal no longer requires scrolling to view the choices in the select's options list. @victorchrollo14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thank you.
Shall I wait for the maintainers to review and make all the suggested changes in a single commit.

1 change: 1 addition & 0 deletions packages/volto/src/components/manage/Widgets/SelectStyling.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export const selectTheme = (theme) => ({
});

export const customSelectStyles = {
menuPortal: (base) => ({ ...base, zIndex: 9999 }),
control: (styles, state) => ({
...styles,
border: 'none',
Expand Down
1 change: 1 addition & 0 deletions packages/volto/src/components/manage/Widgets/SelectWidget.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ class SelectWidget extends Component {
options={options}
styles={customSelectStyles}
theme={selectTheme}
maxMenuHeight="13em"
components={{
...(options?.length > 25 && {
MenuList,
Expand Down
2 changes: 1 addition & 1 deletion packages/volto/src/components/manage/Widgets/__snapshots__/SelectWidget.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ exports[`No 'No value' option when default value is 0 1`] = `
class="react-select__menu css-109xf7j-menu"
>
<div
class="react-select__menu-list css-4ljt47-MenuList"
class="react-select__menu-list css-opcdc2-MenuList"
>
<div
class="react-select__option react-select__option--is-focused react-select__option--is-selected css-zq2nh-option"
Expand Down
Loading