Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set constraints after setting local permissions on content #38

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Set constraints after setting local permissions on content #38

merged 3 commits into from
Sep 27, 2024

Conversation

ericof
Copy link
Member

@ericof ericof commented Sep 18, 2024

Fixes #33

@ericof ericof requested a review from davisagli September 18, 2024 13:32
davisagli
davisagli reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericof It should say "constraints" everywhere instead of "constrains" (noun vs verb)

@ericof ericof changed the title Set constrains after setting local permissions on content Set constraints after setting local permissions on content Sep 19, 2024
@ericof ericof requested a review from davisagli September 20, 2024 20:10
@davisagli
Copy link
Member

@ericof Could you resolve the conflict please?

@davisagli davisagli merged commit fdaa795 into main Sep 27, 2024
7 checks passed
@davisagli davisagli deleted the issue-33-permission-constrains branch September 27, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importer: Local permissions should be set before update_constrains
2 participants
@ericof @davisagli