Fix pnpm on runtime #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
reviewed
Oct 24, 2024
| @@ -25,7 +25,10 @@ USER node | |||
|
|
|||
| # Set working directory to /app | |||
| WORKDIR /app | |||
| RUN corepack use pnpm@9 | |||
| # Upgrades pnpm to the latest version globally | |||
| RUN corepack install -g pnpm | |||
There was a problem hiding this comment.
@sneridagh Why do we need a global one and not just the one for the project?
There was a problem hiding this comment.
@davisagli we can remove this, but I thought that we might want to have the global one updated too (it's pnpm 8 still if 20-slim is used, at least the last time I checked). So we first update it globally, then just install the specified version in package.json afterwards.
There was a problem hiding this comment.
@sneridagh But why do we need a global installation in the image at all? Who or what will try to run pnpm inside the container but not in the /app directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ericof This will fix the problem that pnpm tries to download on runtime.
However, it has a flaw, because if anybody updates the packageManager key in the project (eg. it's not in sync with Volto's), it will fail again in containers without outside access.
So somehow we have to change the
Dockerfilein apps as well :( Let's talk when you are around.