chore: orca worktree setup 추가 (orca.yaml + .worktreeinclude)#278
Conversation
mise 미사용 변형 사용(bun이 PATH에 있는 단일 패키지 저장소). .worktreeinclude로 .env* 및 .claude/settings.local.json 복사 대상 지정.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds ChangesRepository Setup and Local Config
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
orca.yaml (2)
13-18: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winMake setup execution path-explicit and validate required env vars.
For deterministic behavior, guard
ORCA_ROOT_PATH/ORCA_WORKTREE_PATHand run install from the worktree explicitly.Proposed hardening
scripts: setup: | - set -e + set -euo pipefail + : "${ORCA_ROOT_PATH:?ORCA_ROOT_PATH is required}" + : "${ORCA_WORKTREE_PATH:?ORCA_WORKTREE_PATH is required}" # 1. gitignored 로컬 파일(.env*, .claude/settings.local.json)을 메인 체크아웃에서 worktree로 복사. bunx `@pleaseai/worktreeinclude` "$ORCA_ROOT_PATH" "$ORCA_WORKTREE_PATH" # 2. worktree 안에서 의존성 설치. - bun install + cd "$ORCA_WORKTREE_PATH" + bun install🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@orca.yaml` around lines 13 - 18, The setup script currently relies on implicit working-directory behavior and unvalidated env vars. Update the setup block in orca.yaml to explicitly verify ORCA_ROOT_PATH and ORCA_WORKTREE_PATH are set before use, then run the dependency install from the worktree path rather than relying on the current directory. Keep the existing worktree-copy step with bunx `@pleaseai/worktreeinclude`, and make the install step path-explicit so setup is deterministic.
16-16: 🔒 Security & Privacy | 🔵 TrivialPin
@pleaseai/worktreeincludeto a fixed version.
bunx@pleaseai/worktreeinclude@<version> "$ORCA_ROOT_PATH" "$ORCA_WORKTREE_PATH"keeps setup behavior stable as releases change over time.Proposed adjustment
- bunx `@pleaseai/worktreeinclude` "$ORCA_ROOT_PATH" "$ORCA_WORKTREE_PATH" + bunx `@pleaseai/worktreeinclude`@<version> "$ORCA_ROOT_PATH" "$ORCA_WORKTREE_PATH"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@orca.yaml` at line 16, The setup command in the Orca workflow uses an unpinned `@pleaseai/worktreeinclude` package, which can change behavior as new releases are published. Update the bunx invocation in the Orca configuration to reference a fixed version of `@pleaseai/worktreeinclude` so the worktree setup remains stable over time. Use the existing bunx `@pleaseai/worktreeinclude` call as the location to adjust, keeping the same ORCA_ROOT_PATH and ORCA_WORKTREE_PATH arguments.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.worktreeinclude:
- Around line 8-10: The include patterns in the worktree config are narrower
than the stated `.env*` intent, since they only cover base and `.local` variants
and miss non-local environment files like `.env.development`. Update the
matching entries around the `.env` patterns so they align with the intended
scope, or adjust the documented intent if the narrower set is correct. Keep the
change localized to the existing `.env`, `.env.local`, and `.env.*.local`
entries.
---
Nitpick comments:
In `@orca.yaml`:
- Around line 13-18: The setup script currently relies on implicit
working-directory behavior and unvalidated env vars. Update the setup block in
orca.yaml to explicitly verify ORCA_ROOT_PATH and ORCA_WORKTREE_PATH are set
before use, then run the dependency install from the worktree path rather than
relying on the current directory. Keep the existing worktree-copy step with bunx
`@pleaseai/worktreeinclude`, and make the install step path-explicit so setup is
deterministic.
- Line 16: The setup command in the Orca workflow uses an unpinned
`@pleaseai/worktreeinclude` package, which can change behavior as new releases are
published. Update the bunx invocation in the Orca configuration to reference a
fixed version of `@pleaseai/worktreeinclude` so the worktree setup remains stable
over time. Use the existing bunx `@pleaseai/worktreeinclude` call as the location
to adjust, keeping the same ORCA_ROOT_PATH and ORCA_WORKTREE_PATH arguments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0ae991d0-f955-4b02-88fb-19e0ed8f0a43
📒 Files selected for processing (2)
.worktreeincludeorca.yaml
| .env | ||
| .env.local | ||
| .env.*.local |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
.env* intent and include patterns are currently misaligned.
Current patterns skip non-.local variants (for example .env.development). If the intended behavior is truly .env*, add a broader pattern or narrow the comment/objective wording to match implementation.
Proposed adjustment
.env
.env.local
+.env.*
.env.*.local📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .env | |
| .env.local | |
| .env.*.local | |
| .env | |
| .env.local | |
| .env.* | |
| .env.*.local |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.worktreeinclude around lines 8 - 10, The include patterns in the worktree
config are narrower than the stated `.env*` intent, since they only cover base
and `.local` variants and miss non-local environment files like
`.env.development`. Update the matching entries around the `.env` patterns so
they align with the intended scope, or adjust the documented intent if the
narrower set is correct. Keep the change localized to the existing `.env`,
`.env.local`, and `.env.*.local` entries.
Plan and memory documents under .please/ contain illustrative code blocks that fail style linting (no-multi-spaces, operator-linebreak, member-delimiter-style). Treat them the same as docs/ and docs-dev/ documentation markdown, which are already ignored, to unbreak the lint check.
|
1 participant
Summary
Add Orca worktree configuration files to support isolated worktree-based development workflows.
Changes
bunx @pleaseai/worktreeincludefollowed bybun installdirectly, since this is a single-package repo with bun on PATH (no mise task runner needed)..env*and.claude/settings.local.jsonso worktrees inherit local environment and Claude Code settings without polluting tracked history.Rationale
This repo does not use mise (no
mise.toml), so the standardtemplates/orca.yaml(which calls mise tasks) does not apply. The non-mise variant callsbunx/bun installdirectly, which is appropriate for a bun-native single-package repository.Test Plan
orca.yamlis valid YAML and readable by the Orca CLI.worktreeincludecorrectly lists paths to copy into new worktrees.env*and.claude/settings.local.jsonare presentNotes
.claude/settings.local.jsonis gitignored via.git/info/exclude(not.gitignore), which is why it must be listed in.worktreeincludefor worktree copying.Summary by cubic
Add
orca.yamland.worktreeincludeto auto-copy local config into new worktrees and install dependencies with Bun, using a frozen lockfile to keep worktrees clean. Also ignore.please/**/*.mdin ESLint to unbreak lint checks and set Claude output language to English.Written for commit ca35e03. Summary will update on new commits.
Summary by CodeRabbit
.worktreeincludefile to define which ignored local files are eligible for inclusion, including root.envvariants and local Claude settings..gitignore-style patterns are used to determine which files get copied into worktrees.