Skip to content

chore(claude): consolidate code-intelligence LSP plugins#64

Merged
amondnet merged 1 commit into
mainfrom
amondnet/wiki
Jul 1, 2026
Merged

chore(claude): consolidate code-intelligence LSP plugins#64
amondnet merged 1 commit into
mainfrom
amondnet/wiki

Conversation

@amondnet

@amondnet amondnet commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Consolidate the code-intelligence LSP plugins into a single entry and prune unused/duplicate enabled plugins in .claude/settings.json.

Changes

  • Replace typescript-lsp@code-intelligence, rust-analyzer-lsp@code-intelligence, eslint-lsp@code-intelligence with the single code-intelligence-lsp@code-intelligence plugin
  • Remove code-review@pleaseai, please@passionfactory, standards@passionfactory, review@passionfactory, plannotator@passionfactory from enabledPlugins
  • Keep bun@pleaseai and claude-md-management@claude-plugins-official

Test Plan

  • Reviewed the diff — only .claude/settings.json changed, no runtime code affected

Summary by cubic

Consolidated LSP plugins in .claude/settings.json: replaced typescript-lsp@code-intelligence, rust-analyzer-lsp@code-intelligence, and eslint-lsp@code-intelligence with code-intelligence-lsp@code-intelligence; removed code-review@pleaseai, please@passionfactory, standards@passionfactory, review@passionfactory, plannotator@passionfactory. Kept bun@pleaseai and claude-md-management@claude-plugins-official; simpler config, no runtime changes.

Written for commit 92ee8b0. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Streamlined the set of enabled AI-related plugins to keep only the most relevant ones, which may improve consistency and reduce clutter in the workspace.

typescript-lsp, rust-analyzer-lsp, eslint-lsp를 code-intelligence-lsp@code-intelligence
단일 플러그인으로 통합하고, code-review@pleaseai / please@passionfactory /
standards@passionfactory / review@passionfactory / plannotator@passionfactory를
enabledPlugins에서 제거했다. bun@pleaseai와
claude-md-management@claude-plugins-official는 유지한다.
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0557e124-8042-49ec-8cd2-9fa03b4d675f

📥 Commits

Reviewing files that changed from the base of the PR and between 57fb53c and 92ee8b0.

📒 Files selected for processing (1)
  • .claude/settings.json

📝 Walkthrough

Walkthrough

The change modifies the enabledPlugins configuration in .claude/settings.json, removing several previously enabled plugin entries and retaining only three: code-intelligence-lsp@code-intelligence, bun@pleaseai, and claude-md-management@claude-plugins-official.

Changes

Plugin configuration update

Layer / File(s) Summary
Reduce enabled plugins list
.claude/settings.json
The enabledPlugins array is pruned from multiple entries down to three: code-intelligence-lsp@code-intelligence, bun@pleaseai, and claude-md-management@claude-plugins-official.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: consolidating code-intelligence LSP plugin entries in .claude/settings.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch amondnet/wiki

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the '.claude/settings.json' file by removing several language-specific LSP and utility plugins in favor of a single 'code-intelligence-lsp' plugin. The review feedback correctly identifies that this consolidated plugin does not exist in the official marketplace, which would break code intelligence for TypeScript and Rust. The reviewer suggests using the official, individual LSP plugins instead.

Comment thread .claude/settings.json
@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown

Greptile Summary

This PR simplifies .claude/settings.json by consolidating three individual code-intelligence LSP plugins into a single unified entry and removing five plugins that are described as unused or duplicate.

  • Three plugins (typescript-lsp, rust-analyzer-lsp, eslint-lsp, all from the code-intelligence provider) are replaced by the single code-intelligence-lsp@code-intelligence plugin.
  • Five plugins (code-review@pleaseai, please@passionfactory, standards@passionfactory, review@passionfactory, plannotator@passionfactory) are removed entirely; only bun@pleaseai and claude-md-management@claude-plugins-official are kept alongside the new consolidated LSP plugin.

Confidence Score: 5/5

Safe to merge — only the Claude plugin list in .claude/settings.json changes; no runtime code, logic, or data is affected.

The change is limited to a JSON configuration file that controls which Claude IDE plugins are enabled. The consolidation of three individual LSP plugins into one unified plugin is a straightforward housekeeping change, and the removed passionfactory/pleaseai plugins are described as unused. There is nothing here that could introduce a regression in the codebase itself.

No files require special attention.

Important Files Changed

Filename Overview
.claude/settings.json Consolidates three individual code-intelligence LSP plugin entries into one unified code-intelligence-lsp@code-intelligence entry and removes five unused passionfactory/pleaseai plugins; retains bun@pleaseai and claude-md-management@claude-plugins-official.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph BEFORE["Before (base branch)"]
        A1["typescript-lsp@code-intelligence"]
        A2["rust-analyzer-lsp@code-intelligence"]
        A3["eslint-lsp@code-intelligence"]
        A4["bun@pleaseai"]
        A5["claude-md-management@claude-plugins-official"]
        A6["code-review@pleaseai"]
        A7["please@passionfactory"]
        A8["standards@passionfactory"]
        A9["review@passionfactory"]
        A10["plannotator@passionfactory"]
    end

    subgraph AFTER["After (this PR)"]
        B1["code-intelligence-lsp@code-intelligence"]
        B2["bun@pleaseai"]
        B3["claude-md-management@claude-plugins-official"]
    end

    A1 & A2 & A3 -->|"consolidated"| B1
    A4 -->|"kept"| B2
    A5 -->|"kept"| B3
    A6 & A7 & A8 & A9 & A10 -->|"removed"| X["Pruned (unused/duplicate)"]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    subgraph BEFORE["Before (base branch)"]
        A1["typescript-lsp@code-intelligence"]
        A2["rust-analyzer-lsp@code-intelligence"]
        A3["eslint-lsp@code-intelligence"]
        A4["bun@pleaseai"]
        A5["claude-md-management@claude-plugins-official"]
        A6["code-review@pleaseai"]
        A7["please@passionfactory"]
        A8["standards@passionfactory"]
        A9["review@passionfactory"]
        A10["plannotator@passionfactory"]
    end

    subgraph AFTER["After (this PR)"]
        B1["code-intelligence-lsp@code-intelligence"]
        B2["bun@pleaseai"]
        B3["claude-md-management@claude-plugins-official"]
    end

    A1 & A2 & A3 -->|"consolidated"| B1
    A4 -->|"kept"| B2
    A5 -->|"kept"| B3
    A6 & A7 & A8 & A9 & A10 -->|"removed"| X["Pruned (unused/duplicate)"]
Loading

Reviews (1): Last reviewed commit: "chore(claude): code-intelligence LSP 플러그..." | Re-trigger Greptile

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Architecture diagram
sequenceDiagram
    participant Claude as Claude Desktop
    participant Settings as .claude/settings.json
    participant PluginLoader as Plugin Loader
    participant CI as code-intelligence-lsp@code-intelligence
    participant TS as typescript-lsp@code-intelligence
    participant RA as rust-analyzer-lsp@code-intelligence
    participant ESL as eslint-lsp@code-intelligence
    participant Others as Removed Plugins

    Note over Claude,Others: Configuration Parsing at Startup

    Claude->>Settings: Read enabledPlugins
    Settings-->>Claude: {"code-intelligence-lsp": true, "bun": true, "claude-md-management": true}

    Claude->>PluginLoader: Initialize plugins from enabled list

    PluginLoader->>CI: Load code-intelligence-lsp@code-intelligence
    PluginLoader-xOthers: Skip code-review@pleaseai (not enabled)
    PluginLoader-xOthers: Skip please@passionfactory
    PluginLoader-xOthers: Skip standards@passionfactory
    PluginLoader-xOthers: Skip review@passionfactory
    PluginLoader-xOthers: Skip plannotator@passionfactory
    PluginLoader-->>Claude: Plugin initialization complete

    Note over CI,Runtime: Code Intelligence Features (now consolidated)

    Claude->>CI: Request file analysis
    CI->>CI: Handle TypeScript, Rust, ESLint via single plugin
    Note right of CI: Unified LSP integration replaces 3 separate plugins
    CI-->>Claude: Analysis results

    Note over Others: Legacy plugins no longer loaded
Loading

Re-trigger cubic

@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 5 untouched benchmarks


Comparing amondnet/wiki (92ee8b0) with main (57fb53c)

Open in CodSpeed

@amondnet amondnet self-assigned this Jul 1, 2026
@amondnet
amondnet merged commit a226b05 into main Jul 1, 2026
13 checks passed
@amondnet
amondnet deleted the amondnet/wiki branch July 1, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant