chore(release): add LSP plugin extra-files to release-please config#92
Conversation
Add 32 LSP plugin plugin.json paths to the root package extra-files in release-please-config.json so that release-please automatically updates the version field in each plugin's plugin.json when a root package release is created. Previously, only .claude-plugin/plugin.json was listed in extra-files, requiring manual version management for all LSP plugins. Plugins added: - astro-lsp, bash-lsp, biome-lsp, clangd-lsp, csharp-lsp - dart-lsp, deno-lsp, dockerfile-lsp, elixir-lsp, eslint-lsp - fsharp-lsp, gleam-lsp, gopls-lsp, graphql-lsp, jdtls-lsp - kotlin-lsp, lua-lsp, ocaml-lsp, oxlint-lsp, php-lsp - prisma-lsp, pyright-lsp, rubocop-lsp, rust-analyzer-lsp - svelte-lsp, swift-lsp, terraform-lsp, texlab-lsp - typescript-lsp, vue-lsp, yaml-lsp, zls-lsp
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 Pull Request는 release-please 설정을 업데이트하여 루트 패키지 릴리스 시 32개의 LSP 플러그인 버전이 자동으로 동기화되도록 합니다. 이는 기존의 수동 버전 관리 방식을 개선하여 릴리스 프로세스의 효율성과 정확성을 향상시키는 것을 목표로 합니다. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying code-please with
|
| Latest commit: |
dfbbda2
|
| Status: | 🚫 Build failed. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
release-please-config.json 파일에 LSP 플러그인들의 plugin.json 경로를 추가하여 릴리스 시 버전이 자동으로 업데이트되도록 수정한 내용을 확인했습니다. 좋은 변경입니다. 다만, 수십 개의 경로를 직접 나열하는 대신 glob 패턴을 사용하면 설정을 더 간결하고 유지보수하기 쉽게 만들 수 있습니다. 관련하여 release-please-config.json 파일에 대한 리뷰 의견을 남겼으니 확인 부탁드립니다.
Note: Security Review has been skipped due to the limited scope of the PR.
1 participant
Summary
.) 릴리스 시 32개 LSP 플러그인의plugin.jsonversion 필드를 자동으로 업데이트하도록extra-files배열에 경로를 추가.claude-plugin/plugin.json만extra-files에 등록되어 있어, LSP 플러그인들의 버전은 수동으로 관리해야 했음plugin.json버전이 자동으로 동기화됨Changes
release-please-config.json의 루트 패키지(.)extra-files에 32개 LSP 플러그인 경로 추가:Test Plan
plugin.jsonversion 필드가 자동으로 업데이트되는지 확인.claude-plugin/plugin.json업데이트가 계속 정상 동작하는지 확인Summary by cubic
Add 32 LSP plugin plugin.json files to the root package’s release-please extra-files so their versions auto-sync on root releases. This removes manual version updates across all LSP plugins.
Written for commit dfbbda2. Summary will update on new commits.