chore(code): bump version to 0.1.12 and add manual publish#85
Conversation
Summary of ChangesHello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version of the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Add workflow_dispatch with publish_only option to manually trigger npm publish without waiting for release-please to create a release. Also add NODE_AUTH_TOKEN for npm publish.
58eed79 to
070dbfe
Compare
Deploying code-please with
|
| Latest commit: |
070dbfe
|
| Status: | ⚡️ Build in progress... |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the version of the @pleaseai/code package from 0.1.11 to 0.1.12 in packages/code/package.json and .release-please-manifest.json. These changes are consistent with the PR's objective to prepare for a new release. The modifications are correct and look good to merge.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/release-please.yml">
<violation number="1" location=".github/workflows/release-please.yml:51">
P2: Using `always()` will run the publish job even if `release-please` fails. Use `!failure() && !cancelled()` instead to allow running when skipped (for `publish_only` mode) but prevent publishing when the release job actually fails.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| publish: | ||
| needs: release-please | ||
| if: ${{ needs.release-please.outputs.release_created == 'true' }} | ||
| if: ${{ always() && (needs.release-please.outputs.release_created == 'true' || inputs.publish_only) }} |
There was a problem hiding this comment.
P2: Using always() will run the publish job even if release-please fails. Use !failure() && !cancelled() instead to allow running when skipped (for publish_only mode) but prevent publishing when the release job actually fails.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/release-please.yml, line 51:
<comment>Using `always()` will run the publish job even if `release-please` fails. Use `!failure() && !cancelled()` instead to allow running when skipped (for `publish_only` mode) but prevent publishing when the release job actually fails.</comment>
<file context>
@@ -40,7 +48,7 @@ jobs:
publish:
needs: release-please
- if: ${{ needs.release-please.outputs.release_created == 'true' }}
+ if: ${{ always() && (needs.release-please.outputs.release_created == 'true' || inputs.publish_only) }}
runs-on: ubuntu-latest
permissions:
</file context>
| if: ${{ always() && (needs.release-please.outputs.release_created == 'true' || inputs.publish_only) }} | |
| if: ${{ !failure() && !cancelled() && (needs.release-please.outputs.release_created == 'true' || inputs.publish_only) }} |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 39.27% 39.27%
=======================================
Files 59 59
Lines 6503 6503
=======================================
Hits 2554 2554
Misses 3949 3949 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Summary
publish_onlyoption for manual npm publishChanges
Manual publish usage
Go to Actions → Release Please → Run workflow → Check "Skip release-please and publish directly"
Summary by cubic
Bumped @pleaseai/code to 0.1.12 with a logger sync mode fix for bundled binaries. Added a manual publish path to let us publish to npm without waiting for a release.
New Features
Bug Fixes
Written for commit 070dbfe. Summary will update on new commits.