feat(plugins): separate LSP servers into individual plugins#81
Conversation
- Add typescript-lsp plugin with official typescript-language-server - Add vue-lsp plugin with @vue/language-server - Add graphql-lsp plugin with graphql-language-service-cli - Update marketplace.json to register all plugins - Remove reflexion plugin (already staged for deletion) Users can now install LSP servers individually from marketplace.
Add standalone ESLint language server plugin using @pleaseai/code wrapper which handles vscode-eslint download, build, and project validation.
Summary of ChangesHello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the modularity and user experience of Language Server Protocol (LSP) integrations. By separating various language servers into individual plugins, users gain greater control and flexibility, enabling them to customize their development environment by installing only the specific language support they require from the marketplace. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively separates various Language Server Protocol (LSP) servers into their own individual plugins, which is a great step towards a more modular and maintainable architecture. The changes are clear and align with the goal of allowing users to install LSP servers as needed. My main feedback across the new plugin configuration files is to pin the versions of the packages being installed via bunx. This is crucial for ensuring stability and reproducibility of the development environment, preventing unexpected issues from upstream package updates.
Deploying code-please with
|
| Latest commit: |
f33b15d
|
| Status: | ⚡️ Build in progress... |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 39.27% 38.62% -0.65%
==========================================
Files 59 59
Lines 6503 6529 +26
==========================================
- Hits 2554 2522 -32
- Misses 3949 4007 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="plugins/graphql-lsp/.claude-plugin/plugin.json">
<violation number="1" location="plugins/graphql-lsp/.claude-plugin/plugin.json:12">
P2: bunx needs the graphql-language-service-cli package specified via `-p` because the executable is `graphql-lsp`, not `graphql-language-service-cli`. As configured, the command will fail to start the server.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- typescript-language-server@^5.1.0 - @vue/language-server@^3.2.0 - graphql-language-service-cli@^3.1.0 (with -p flag for correct executable) - @pleaseai/code@^0.1.0
Use pino.destination({ fd: 2, sync: true }) instead of pino.destination(2)
to avoid thread-stream worker which causes ModuleNotFound errors when
the binary is compiled with Bun and run on different machines.
The sync mode is slightly slower but ensures compatibility with
single-executable binaries where worker paths are hardcoded.
1 participant
Summary
typescript-language-server@vue/language-servergraphql-language-service-cli@pleaseai/codewrapperMotivation
Users can now install LSP servers individually from marketplace based on their needs.
Test plan
.tsfiles.vuefiles.graphqlfilesSummary by cubic
Split LSP servers into standalone plugins so users can install only what they need from the marketplace. Adds TypeScript, Vue, GraphQL, and ESLint LSP plugins, removes the deprecated Reflexion plugin, and fixes logger output for bundled binaries.
New Features
Bug Fixes
Written for commit f33b15d. Summary will update on new commits.