chore: replace submodules with gitignored checkouts#72
Conversation
- Remove all submodules from .gitmodules - Add ref/* to .gitignore (except README.md) - Add ref/README.md with repository list - Add ref:clone script to package.json
Summary of ChangesHello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
이 PR은 git submodule을 gitignore와 bun 스크립트를 사용하는 방식으로 변경하여 참조 저장소를 관리하는 방법을 개선합니다. 전반적으로 좋은 방향의 변경이지만, 몇 가지 중요한 개선점을 제안합니다. 가장 중요한 것은, 새로운 ref:clone 스크립트가 특정 커밋을 고정하지 않아 빌드의 재현성을 해칠 수 있다는 점입니다. 기존 submodule 방식의 장점이었던 버전 고정을 유지하는 것이 필수적입니다. 또한, 저장소 정보가 package.json과 ref/README.md에 중복으로 관리되고 있어 유지보수성을 떨어뜨립니다. ref/README.md를 단일 정보 소스(Single Source of Truth)로 삼고, 스크립트가 이를 읽어오도록 개선하는 것이 좋습니다. 자세한 내용은 각 파일에 남긴 코멘트를 참고해주세요.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 39.35% 39.35%
=======================================
Files 59 59
Lines 6489 6489
=======================================
Hits 2554 2554
Misses 3935 3935 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add Commit column to ref/README.md with pinned hashes - Add git checkout after each clone in ref:clone script - Rename multispy -> multilspy to match repository name
Summary
bun run ref:clone스크립트 추가Changes
.gitmodules삭제.gitignore에ref/*추가 (ref/README.md예외)ref/README.md생성 (저장소 목록)package.json에ref:clone스크립트 추가