Skip to content

chore: replace submodules with gitignored checkouts#72

Merged
amondnet merged 2 commits into
mainfrom
chore/remove-submodules
Jan 15, 2026
Merged

chore: replace submodules with gitignored checkouts#72
amondnet merged 2 commits into
mainfrom
chore/remove-submodules

Conversation

@amondnet

Copy link
Copy Markdown
Contributor

Summary

  • ref/ 디렉토리의 submodule을 제거하고 gitignore 방식으로 변경
  • 참조 저장소 목록을 README.md로 문서화
  • bun run ref:clone 스크립트 추가

Changes

  • .gitmodules 삭제
  • .gitignoreref/* 추가 (ref/README.md 예외)
  • ref/README.md 생성 (저장소 목록)
  • package.jsonref:clone 스크립트 추가

- Remove all submodules from .gitmodules
- Add ref/* to .gitignore (except README.md)
- Add ref/README.md with repository list
- Add ref:clone script to package.json
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 ref/ 디렉토리에서 사용되던 Git 서브모듈을 제거하고, 대신 .gitignore를 통해 해당 디렉토리를 Git 추적에서 제외하는 방식으로 변경합니다. 이는 메인 저장소의 복잡성을 줄이고, 외부 참조 저장소들을 필요에 따라 수동으로 클론하거나 새로 추가된 스크립트를 통해 관리할 수 있도록 유연성을 제공합니다. 이 변경으로 개발 환경 설정이 간소화되고, 서브모듈 관련 문제를 피할 수 있습니다.

Highlights

  • 서브모듈 제거: ref/ 디렉토리에서 Git 서브모듈을 제거하고, .gitignore를 통해 로컬 체크아웃 방식으로 변경했습니다.
  • 참조 저장소 문서화: 참조 저장소 목록을 ref/README.md 파일로 문서화하여 관리합니다.
  • 클론 스크립트 추가: 참조 저장소들을 쉽게 클론할 수 있도록 package.json에 bun run ref:clone 스크립트를 추가했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jan 15, 2026

Copy link
Copy Markdown

Deploying code-please with  Cloudflare Pages  Cloudflare Pages

Latest commit: 09f73f6
Status:🚫  Build failed.

View logs

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 git submodule을 gitignorebun 스크립트를 사용하는 방식으로 변경하여 참조 저장소를 관리하는 방법을 개선합니다. 전반적으로 좋은 방향의 변경이지만, 몇 가지 중요한 개선점을 제안합니다. 가장 중요한 것은, 새로운 ref:clone 스크립트가 특정 커밋을 고정하지 않아 빌드의 재현성을 해칠 수 있다는 점입니다. 기존 submodule 방식의 장점이었던 버전 고정을 유지하는 것이 필수적입니다. 또한, 저장소 정보가 package.jsonref/README.md에 중복으로 관리되고 있어 유지보수성을 떨어뜨립니다. ref/README.md를 단일 정보 소스(Single Source of Truth)로 삼고, 스크립트가 이를 읽어오도록 개선하는 것이 좋습니다. 자세한 내용은 각 파일에 남긴 코멘트를 참고해주세요.

Comment thread package.json Outdated
Comment thread ref/README.md Outdated
@codecov

codecov Bot commented Jan 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.35%. Comparing base (e28a2ea) to head (09f73f6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          59       59           
  Lines        6489     6489           
=======================================
  Hits         2554     2554           
  Misses       3935     3935           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Add Commit column to ref/README.md with pinned hashes
- Add git checkout after each clone in ref:clone script
- Rename multispy -> multilspy to match repository name
@amondnet
amondnet merged commit 7bce41f into main Jan 15, 2026
3 of 4 checks passed
@amondnet
amondnet deleted the chore/remove-submodules branch January 15, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant