Skip to content

fix(ci): use GitHub-hosted runners for npm publish workflow#41

Merged
amondnet merged 2 commits into
mainfrom
fix/npm-publish-github-hosted-runners
Dec 19, 2025
Merged

fix(ci): use GitHub-hosted runners for npm publish workflow#41
amondnet merged 2 commits into
mainfrom
fix/npm-publish-github-hosted-runners

Conversation

@amondnet

Copy link
Copy Markdown
Contributor

Summary

  • Replaced self-hosted runners with ubuntu-latest in the npm publish job
  • npm trusted publishers/provenance feature only supports GitHub-hosted runners
  • Ensures npm package publishing works correctly with trusted publishers authentication

Test plan

  • Verify npm publish workflow runs successfully on next release
  • Confirm workflow uses GitHub-hosted runners (ubuntu-latest)
  • Check npm package is published with correct provenance attestation

Replaced self-hosted runners with ubuntu-latest in the npm publish job
because npm trusted publishers/provenance feature only supports
GitHub-hosted runners. This ensures npm package publishing works
correctly with the trusted publishers authentication method.
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to bolster the security and integrity of the npm package publishing process by migrating the CI workflow to GitHub-hosted runners. This strategic shift is essential for leveraging npm's trusted publishers and provenance features, thereby ensuring a more secure and verifiable release mechanism for packages.

Highlights

  • CI Runner Update: The npm publish workflow has been updated to use GitHub-hosted ubuntu-latest runners instead of self-hosted runners.
  • Trusted Publishers Support: This change is crucial for enabling compatibility with npm's trusted publishers and provenance features, enhancing package security.
  • Authentication Assurance: The update ensures that npm package publishing correctly utilizes trusted publishers authentication for improved security.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/release-please.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the oh-my-opencode submodule. The pull request description indicates that this change is to switch the npm publish workflow to use GitHub-hosted runners (ubuntu-latest) to support npm's trusted publisher feature, which is a good practice. However, the diff provided only contains the update to the submodule reference and not the actual workflow file changes. Assuming the changes within the submodule are as described, this pull request seems correct. As the underlying code changes are not visible in this diff, I have no specific feedback.

@codecov

codecov Bot commented Dec 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.74%. Comparing base (285a0d9) to head (2c4db9e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   49.74%   49.74%           
=======================================
  Files          22       22           
  Lines        4535     4535           
=======================================
  Hits         2256     2256           
  Misses       2279     2279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amondnet
amondnet merged commit 17db1f4 into main Dec 19, 2025
9 checks passed
@amondnet
amondnet deleted the fix/npm-publish-github-hosted-runners branch December 19, 2025 12:44
@passionfactory-bot passionfactory-bot Bot mentioned this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant