fix(ci): use GitHub-hosted runners for npm publish workflow#41
Conversation
Replaced self-hosted runners with ubuntu-latest in the npm publish job because npm trusted publishers/provenance feature only supports GitHub-hosted runners. This ensures npm package publishing works correctly with the trusted publishers authentication method.
Summary of ChangesHello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to bolster the security and integrity of the npm package publishing process by migrating the CI workflow to GitHub-hosted runners. This strategic shift is essential for leveraging npm's trusted publishers and provenance features, thereby ensuring a more secure and verifiable release mechanism for packages. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the oh-my-opencode submodule. The pull request description indicates that this change is to switch the npm publish workflow to use GitHub-hosted runners (ubuntu-latest) to support npm's trusted publisher feature, which is a good practice. However, the diff provided only contains the update to the submodule reference and not the actual workflow file changes. Assuming the changes within the submodule are as described, this pull request seems correct. As the underlying code changes are not visible in this diff, I have no specific feedback.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 49.74% 49.74%
=======================================
Files 22 22
Lines 4535 4535
=======================================
Hits 2256 2256
Misses 2279 2279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
ubuntu-latestin the npm publish jobTest plan