Skip to content

feat(lsp): add ESLint language server support#39

Merged
amondnet merged 1 commit into
mainfrom
38-featlsp-add-eslint-language-server-support
Dec 19, 2025
Merged

feat(lsp): add ESLint language server support#39
amondnet merged 1 commit into
mainfrom
38-featlsp-add-eslint-language-server-support

Conversation

@amondnet

Copy link
Copy Markdown
Contributor

Summary

  • Add ESLint Language Server Protocol support to @pleaseai/code-lsp package
  • Downloads and builds vscode-eslint from GitHub main branch
  • Prerequisite check ensures eslint is installed in the project before starting
  • Supports JS/TS files (.ts, .tsx, .js, .jsx, .mjs, .cjs, .mts, .cts) and Vue (.vue)

Changes

File Description
packages/lsp/src/server.ts Add EslintServer definition with download/build pattern
packages/lsp/src/index.ts Export EslintServer
packages/lsp/CLAUDE.md Update supported servers documentation
packages/lsp/test/unit/server.test.ts Add unit tests for EslintServer

Test plan

  • Typecheck passes
  • Unit tests pass (74 tests, 0 failures)
  • Code review completed
  • Manual testing with project containing eslint

Closes #38

Add ESLint LSP support following the GitHub source build pattern:
- Download vscode-eslint from GitHub main branch
- Build with npm install && npm run compile
- Prerequisite check for eslint package in project
- Support JS/TS extensions (.ts, .tsx, .js, .jsx, .mjs, .cjs, .mts, .cts, .vue)
- Root detection via lock files (package-lock.json, bun.lock, yarn.lock, pnpm-lock.yaml)

Closes #38
@amondnet amondnet linked an issue Dec 19, 2025 that may be closed by this pull request
7 tasks
@codecov

codecov Bot commented Dec 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 13.52941% with 147 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.76%. Comparing base (74117d3) to head (15b9e6b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/lsp/src/server.ts 13.01% 147 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   49.37%   48.76%   -0.62%     
==========================================
  Files          21       22       +1     
  Lines        4324     4561     +237     
==========================================
+ Hits         2135     2224      +89     
- Misses       2189     2337     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amondnet
amondnet merged commit 285a0d9 into main Dec 19, 2025
7 of 9 checks passed
@amondnet
amondnet deleted the 38-featlsp-add-eslint-language-server-support branch December 19, 2025 12:26
@passionfactory-bot passionfactory-bot Bot mentioned this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(lsp): add ESLint language server support

1 participant