Skip to content

fix(release): drop non-functional plugin-pin extra-files, use caret pin #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amondnet merged 2 commits into from
Jul 1, 2026
Merged

fix(release): drop non-functional plugin-pin extra-files, use caret pin #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f426543
fix(release): drop non-functional plugin-pin extra-files, use caret pin
amondnet Jul 1, 2026
75d44ca
fix(plugins): use caret range for @pleaseai/code in remaining LSP plu…
amondnet Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/clangd-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"

@greptile-apps greptile-apps Bot Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Scope creep: 13 "stable" plugins unexpectedly converted to caret ranges

The PR description explicitly says "The other 13 LSP plugins only use the stable code lsp-server command, so they keep their exact 0.1.13 pins. (Converting them to caret ranges too is possible but out of scope here.)" Yet the diff converts all 13 (clangd-lsp, csharp-lsp, dart-lsp, elixir-lsp, eslint-lsp, fsharp-lsp, jdtls-lsp, kotlin-lsp, lua-lsp, rubocop-lsp, terraform-lsp, texlab-lsp, zls-lsp) from 0.1.13 to ^0.1.13. This means these plugins will now silently auto-upgrade to any future 0.1.x patch — behaviour the PR explicitly called out-of-scope. Please confirm this was intentional and update the description accordingly, or revert these 13 files to the exact 0.1.13 pin.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: plugins/clangd-lsp/package.json
Line: 4

Comment:
**Scope creep: 13 "stable" plugins unexpectedly converted to caret ranges**

The PR description explicitly says *"The other 13 LSP plugins only use the stable `code lsp-server` command, so they keep their exact `0.1.13` pins. (Converting them to caret ranges too is possible but out of scope here.)"* Yet the diff converts all 13 (`clangd-lsp`, `csharp-lsp`, `dart-lsp`, `elixir-lsp`, `eslint-lsp`, `fsharp-lsp`, `jdtls-lsp`, `kotlin-lsp`, `lua-lsp`, `rubocop-lsp`, `terraform-lsp`, `texlab-lsp`, `zls-lsp`) from `0.1.13` to `^0.1.13`. This means these plugins will now silently auto-upgrade to any future `0.1.x` patch — behaviour the PR explicitly called out-of-scope. Please confirm this was intentional and update the description accordingly, or revert these 13 files to the exact `0.1.13` pin.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

}
}
2 changes: 1 addition & 1 deletion plugins/code-intelligence-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.14"
"@pleaseai/code": "^0.1.14"
}
}
2 changes: 1 addition & 1 deletion plugins/csharp-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/dart-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/elixir-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/eslint-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/fsharp-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/jdtls-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/kotlin-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/lua-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/rubocop-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/terraform-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/texlab-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
2 changes: 1 addition & 1 deletion plugins/zls-lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"dependencies": {
"@pleaseai/code": "0.1.13"
"@pleaseai/code": "^0.1.13"
}
}
18 changes: 1 addition & 17 deletions release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,23 +65,7 @@
},
"packages/code": {
"release-type": "node",
"component": "@pleaseai/code",
"extra-files": [
{ "type": "json", "path": "plugins/clangd-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/code-intelligence-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/csharp-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/dart-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/elixir-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/eslint-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/fsharp-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/jdtls-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/kotlin-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/lua-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/rubocop-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/terraform-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/texlab-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" },
{ "type": "json", "path": "plugins/zls-lsp/package.json", "jsonpath": "$.dependencies['@pleaseai/code']" }
]
"component": "@pleaseai/code"
Comment thread
amondnet marked this conversation as resolved.
},
"packages/dora": {
"release-type": "node",
Expand Down
Loading