chore: keep release-please pre-1.0 (bump-minor-pre-major) - #11
Merged
Conversation
Breaking changes before 1.0.0 should bump the minor (0.2.0 -> 0.3.0), not jump to 1.0.0. The library's public API is still evolving, so defer the 1.0 stability commitment.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe root release-please package configuration now sets ChangesRelease-please config
Estimated review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
bump-minor-pre-major: trueso release-please bumps the minor for breaking changes while the library is pre-1.0, instead of jumping to 1.0.0.Why
The open release PR #7 proposed 1.0.0 because the
fix(errors)!breaking change (#8) triggers release-please's default major bump. The public API is still evolving (0.2.0, modules recently added), so we want 0.3.0, not a 1.0 stability commitment yet.Effect
After this merges, release-please re-runs on
mainand regenerates the release PR (#7) as 0.3.0. Merging that PR then cuts the release.Summary by cubic
Configure
release-pleaseto bump the minor version for breaking changes while pre-1.0 by enablingbump-minor-pre-major. This keeps@pleaseai/cli-toolkiton 0.x and targets 0.3.0 for the next release instead of 1.0.0.Written for commit 9f50eb5. Summary will update on new commits.
Summary by CodeRabbit