Skip to content

chore: keep release-please pre-1.0 (bump-minor-pre-major) - #11

Merged
amondnet merged 1 commit into
mainfrom
chore/release-please-pre-major
Jun 27, 2026
Merged

chore: keep release-please pre-1.0 (bump-minor-pre-major)#11
amondnet merged 1 commit into
mainfrom
chore/release-please-pre-major

Conversation

@amondnet

@amondnet amondnet commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Sets bump-minor-pre-major: true so release-please bumps the minor for breaking changes while the library is pre-1.0, instead of jumping to 1.0.0.

Why

The open release PR #7 proposed 1.0.0 because the fix(errors)! breaking change (#8) triggers release-please's default major bump. The public API is still evolving (0.2.0, modules recently added), so we want 0.3.0, not a 1.0 stability commitment yet.

Effect

After this merges, release-please re-runs on main and regenerates the release PR (#7) as 0.3.0. Merging that PR then cuts the release.


Summary by cubic

Configure release-please to bump the minor version for breaking changes while pre-1.0 by enabling bump-minor-pre-major. This keeps @pleaseai/cli-toolkit on 0.x and targets 0.3.0 for the next release instead of 1.0.0.

Written for commit 9f50eb5. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated release versioning behavior so pre-major releases will now move forward with minor-version bumps.

Breaking changes before 1.0.0 should bump the minor (0.2.0 -> 0.3.0), not jump
to 1.0.0. The library's public API is still evolving, so defer the 1.0 stability
commitment.
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 12bbb49c-83d5-4b95-93de-b7c004f7cf97

📥 Commits

Reviewing files that changed from the base of the PR and between 0c8350c and 9f50eb5.

📒 Files selected for processing (1)
  • release-please-config.json

📝 Walkthrough

Walkthrough

The root release-please package configuration now sets bump-minor-pre-major to true.

Changes

Release-please config

Layer / File(s) Summary
Root package versioning flag
release-please-config.json
packages["."] now includes bump-minor-pre-major: true.

Estimated review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hopped through the config with a twitch of my nose,
Found one tiny flag where the versioning grows.
A minor bump before major? Yes, that’s the cue,
Thump-de-dump—release-please, I see you! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to release-please pre-1.0 bump behavior and is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/release-please-pre-major

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release-please-config.json file to enable the bump-minor-pre-major option for the @pleaseai/cli-toolkit package. There are no review comments, and I have no feedback to provide.

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@greptile-apps

greptile-apps Bot commented Jun 27, 2026

Copy link
Copy Markdown

Greptile Summary

Adds bump-minor-pre-major: true to the release-please package config so that breaking-change commits (e.g. fix!) increment the minor rather than triggering a major bump while the library is still pre-1.0.

  • The option is placed correctly inside the per-package block (".") and is a recognized release-please config field — it will cause the pending release PR chore(main): release 0.3.0 #7 to be regenerated as 0.3.0 instead of 1.0.0.
  • No other release configuration is altered; include-v-in-tag, extra-files, and changelog-path are all unchanged.

Confidence Score: 5/5

This is a single-line config addition with a well-understood, intentional effect on release versioning — safe to merge.

The change is minimal and correct: bump-minor-pre-major is placed in the right scope (per-package), the value is boolean, and the intent (keeping the next release at 0.3.0 rather than 1.0.0) is exactly what this option does. There is no application code, no logic change, and no migration risk.

No files require special attention.

Important Files Changed

Filename Overview
release-please-config.json Adds bump-minor-pre-major: true at the package level so release-please treats breaking changes as minor bumps while the package is pre-1.0; no other fields are touched.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Breaking change merged\ne.g. fix!] --> B{release-please\nevaluates bump type}
    B -- bump-minor-pre-major: false\n(old default) --> C[Major bump\n0.2.0 → 1.0.0]
    B -- bump-minor-pre-major: true\n(this PR) --> D[Minor bump\n0.2.0 → 0.3.0]
    C --> E[Release PR: v1.0.0\n⚠ premature stability commitment]
    D --> F[Release PR: v0.3.0\n✓ stays pre-1.0]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Breaking change merged\ne.g. fix!] --> B{release-please\nevaluates bump type}
    B -- bump-minor-pre-major: false\n(old default) --> C[Major bump\n0.2.0 → 1.0.0]
    B -- bump-minor-pre-major: true\n(this PR) --> D[Minor bump\n0.2.0 → 0.3.0]
    C --> E[Release PR: v1.0.0\n⚠ premature stability commitment]
    D --> F[Release PR: v0.3.0\n✓ stays pre-1.0]
Loading

Reviews (1): Last reviewed commit: "chore: keep release-please pre-1.0 (bump..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@amondnet
amondnet merged commit 95eb4b7 into main Jun 27, 2026
7 checks passed
@amondnet
amondnet deleted the chore/release-please-pre-major branch June 27, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant