Skip to content

ci: remove Graphite CI optimizer and its token - #239

Merged
amondnet merged 1 commit into
mainfrom
amondnet/opt
Jun 30, 2026
Merged

ci: remove Graphite CI optimizer and its token#239
amondnet merged 1 commit into
mainfrom
amondnet/opt

Conversation

@amondnet

@amondnet amondnet commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the optimize_ci job and its associated GRAPHITE_CI_OPTIMIZER_TOKEN secret dependency from .github/workflows/ci.yml.

Changes

  • Dropped the entire optimize_ci job, which was the sole consumer of GRAPHITE_CI_OPTIMIZER_TOKEN
  • Removed needs: optimize_ci from lint, build, typecheck, and test jobs
  • Removed if: needs.optimize_ci.outputs.skip == 'false' conditions from those jobs
  • The four CI jobs now run unconditionally on every push/PR to main

Notes

bun.lock drift (gatekeeper 1.4.0→1.5.0 sync) was intentionally excluded from this commit to keep the change atomic.


Summary by cubic

Simplifies CI by removing the Graphite optimizer job and its token, so lint, build, typecheck, and test run on every push and PR.

  • Refactors
    • Removed optimize_ci job from .github/workflows/ci.yml.
    • Dropped needs: optimize_ci and if: needs.optimize_ci.outputs.skip == 'false' from lint, build, typecheck, and test.
    • Removed dependency on the GRAPHITE_CI_OPTIMIZER_TOKEN secret.

Written for commit 236e4df. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Simplified the continuous integration workflow by removing an optimization step.
    • Validation jobs now run directly without conditional gating, making checks more consistent.

The optimize_ci job required GRAPHITE_CI_OPTIMIZER_TOKEN to conditionally
skip downstream jobs. That secret has been removed, so the entire
optimize_ci job is dropped along with the needs: optimize_ci guard and the
if: needs.optimize_ci.outputs.skip == 'false' condition on lint, build,
typecheck, and test. Those four jobs now run unconditionally on every
push/PR to main.

Note: bun.lock drift (gatekeeper 1.4.0→1.5.0 sync) is intentionally
excluded from this commit to keep the change atomic.
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
claude-code-plugins Ready Ready Preview, Comment Jun 30, 2026 5:00am

Request Review

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ca6ab147-b0bc-4ea2-99f8-5e6ffa99a624

📥 Commits

Reviewing files that changed from the base of the PR and between 7e54860 and 236e4df.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The optimize_ci Graphite CI optimizer job is removed from .github/workflows/ci.yml. The lint, build, typecheck, and test jobs no longer depend on or conditionally gate on its output; they now run unconditionally.

Changes

CI Workflow

Layer / File(s) Summary
Remove optimize_ci gate from all jobs
.github/workflows/ci.yml
Deletes the optimize_ci job and removes needs: optimize_ci and if: needs.optimize_ci.outputs.skip == 'false' from lint, build, typecheck, and test jobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 No more gatekeeper, no more delay,
The CI jobs run free every day!
Graphite optimizer, farewell to thee,
lint, build, typecheck — all running with glee.
The rabbit hops fast, unblocked and bright! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main CI workflow change by removing the Graphite optimizer job and its token dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch amondnet/opt

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@greptile-apps

greptile-apps Bot commented Jun 30, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the Graphite CI optimizer integration from the workflow by dropping the optimize_ci job and the needs/if conditions that gated the lint, build, typecheck, and test jobs on its output. No other workflow files reference the removed job or token.

  • The four CI jobs (lint, build, typecheck, test) now run unconditionally and fully in parallel on every push/PR to main, eliminating the sequential dependency on the Graphite gate.
  • The GRAPHITE_CI_OPTIMIZER_TOKEN secret is no longer consumed anywhere in the repository after this change, so it can safely be removed from GitHub Settings → Secrets.

Confidence Score: 5/5

This PR is safe to merge — the removal is clean, the four remaining jobs are unchanged in behaviour, and no dangling references to the removed token or job remain anywhere in the repo.

The change deletes a single gate job and its associated conditionals. All four CI jobs previously gated by it are intact, their steps are unmodified, and a repo-wide search confirms no other workflow or config still references GRAPHITE_CI_OPTIMIZER_TOKEN or optimize_ci. The net effect is that CI now always runs all four jobs in parallel, which is simpler and faster.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Removes the optimize_ci gate job and its needs/if guards from all four CI jobs; the four jobs now run unconditionally and fully in parallel on every push/PR to main.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph BEFORE["Before (removed)"]
        B_trigger["push / pull_request"] --> B_opt["optimize_ci\n(Graphite API gate)"]
        B_opt -- "skip == 'false'" --> B_lint["lint"]
        B_opt -- "skip == 'false'" --> B_build["build"]
        B_opt -- "skip == 'false'" --> B_tc["typecheck"]
        B_opt -- "skip == 'false'" --> B_test["test"]
    end

    subgraph AFTER["After (this PR)"]
        A_trigger["push / pull_request"] --> A_lint["lint"]
        A_trigger --> A_build["build"]
        A_trigger --> A_tc["typecheck"]
        A_trigger --> A_test["test"]
    end
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    subgraph BEFORE["Before (removed)"]
        B_trigger["push / pull_request"] --> B_opt["optimize_ci\n(Graphite API gate)"]
        B_opt -- "skip == 'false'" --> B_lint["lint"]
        B_opt -- "skip == 'false'" --> B_build["build"]
        B_opt -- "skip == 'false'" --> B_tc["typecheck"]
        B_opt -- "skip == 'false'" --> B_test["test"]
    end

    subgraph AFTER["After (this PR)"]
        A_trigger["push / pull_request"] --> A_lint["lint"]
        A_trigger --> A_build["build"]
        A_trigger --> A_tc["typecheck"]
        A_trigger --> A_test["test"]
    end
Loading

Reviews (1): Last reviewed commit: "ci: remove Graphite CI optimizer and its..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant GHA as GitHub Actions
    participant WF as CI Workflow
    participant Lint as lint
    participant Build as build
    participant Typecheck as typecheck
    participant Test as test

    Note over GHA,WF: On push/PR to main
    GHA->>WF: Trigger workflow
    WF->>Lint: Run (no conditional gate)
    WF->>Build: Run (no conditional gate)
    WF->>Typecheck: Run (no conditional gate)
    WF->>Test: Run (no conditional gate)
    Lint-->>WF: result
    Build-->>WF: result
    Typecheck-->>WF: result
    Test-->>WF: result
    WF-->>GHA: Workflow success/failure
Loading

Re-trigger cubic

@amondnet
amondnet merged commit 744e3e2 into main Jun 30, 2026
13 checks passed
@amondnet
amondnet deleted the amondnet/opt branch June 30, 2026 05:07
@amondnet amondnet self-assigned this Jun 30, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant