ci: build CLI via turbo to resolve workspace deps#28
Merged
Conversation
tsc in packages/cli failed with TS2307 for @pleaseai/registry-schema because the workflow built only the CLI, skipping the schema package whose exports point to ./dist/*. Use turbo --filter to build the dependency graph in order.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tscinpackages/clifails withTS2307: Cannot find module '@pleaseai/registry-schema'during the release workflow.Root Cause
The release workflow's Build CLI step ran
bun run --cwd packages/cli build, which only builds the CLI. The workspace dependency@pleaseai/registry-schemahasexportspointing to./dist/*, but itsdist/is never produced — sotscin the CLI cannot resolve the type declarations.Changes
bun run build --filter=@pleaseai/ask, delegating to rootturbo buildwhich respects the workspace dependency graph and builds@pleaseai/registry-schemabefore the CLI.Test Plan
Summary by cubic
Build the CLI via Turbo in the release workflow to respect workspace deps and prevent TS2307 errors. This ensures
@pleaseai/registry-schemais built before the CLI.bun run --cwd packages/cli buildwithbun run build --filter=@pleaseai/askso@pleaseai/registry-schemaproducesdist/before@pleaseai/askbuilds.Written for commit 49c8f7a. Summary will update on new commits.