-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a Vogel spiral in the sampling method of PCSS for directional light #7371
Conversation
PCSS: Use a Vogel spiral in a sampling method
6e87a80
to
cad9717
Compare
@mvaligursky Now I know why we use pow here. Falloff: 10 vec2 offset = vec2(cos(theta), sin(theta)) * pow(r, 0.75); vec2 offset = vec2(cos(theta), sin(theta)) * r; vec2 offset = vec2(cos(theta), sin(theta)) * pow(r, 1.333); // 1.0 / 0.75 What do you think about it? |
It seems like this could work? Update the PR so I can run it locally to test. |
@mvaligursky Done: |
Perfect @querielo, this behaves equivalently now with visibly less noise, especially when the number of samples is low. |
@mvaligursky Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic change, thanks!
Vogel spiral distribution reduces visible noise and achieves more uniform sample coverage.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.