Moved zero render target checked to a better place #7354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklundin
reviewed
Feb 14, 2025
| @@ -150,6 +150,12 @@ class WebglRenderTarget { | |||
|
|
|||
| } else { | |||
|
|
|||
| Debug.call(() => { | |||
There was a problem hiding this comment.
This will just warn though. It won't resize the render targets back right?
There was a problem hiding this comment.
true.
this will cause webgl errors as well.
as discussed in the previous duplicate issue, the engine does not support this way of hiding the application, and it should not be used.
There was a problem hiding this comment.
it does work without the post though. If you do the same thing without the camera frame it will work correctly
There was a problem hiding this comment.
yes because normally we do not render to any render target
with camera frame or old post effects we render to render target, and currently we do not support when those are 0 size
willeastcott
approved these changes
Feb 22, 2025
mvaligursky
added a commit
that referenced
this pull request
Feb 24, 2025
Co-authored-by: Martin Valigursky <[email protected]>
mvaligursky
added a commit
that referenced
this pull request
Feb 26, 2025
Co-authored-by: Martin Valigursky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to handle single samplered RTs as well, not only multisampled
Related to #7351
repro using engine example
note that this is not related to CameraFrame only, but any render target rendering, even old post-effects.