Repository navigation
Conversation
|
apata
commented
Oct 28, 2026
Comment on lines
+182
to
+188
| // react-router applies the URL change in a transition, so the draft must | ||
| // be cleared in one too, or the filter disappears between the two commits | ||
| startTransition(() => { | ||
| setEditing({ | ||
| ...current, | ||
| draft: null, | ||
| hasPushedHistoryEntry: true |
Contributor
Author
There was a problem hiding this comment.
This fix looks flimsier than I'd like, but manual testing confirms that it's working. We have previously talked about refactoring this module to do less, but haven't gotten to it, so maybe it's acceptable to have this hacky fix until we do.
Contributor
There was a problem hiding this comment.
There's another case right above (the setEditing call in the if (!hasValues(filter)) branch, line 167) that should be wrapped with startTransition:
- Add a "Source is Google" filter
- Open its value picker
- De-select Google
- Notice how a second pill flickers next to the one we're currently editing
I agree that it's acceptable as a patch, but would be nice to fix it properly by making sure the filters pills are rendered based on a single source of truth.
Contributor
Author
There was a problem hiding this comment.
Ah damn, thanks for finding that! Let's do it right then.
RobertJoonas
approved these changes
Oct 29, 2026
apata
marked this pull request as draft
October 29, 2026 12:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Ran
npm --prefix assets audit --fix, then updatedreact-routerone major version, from 6 to 7. Latest major is 8, which requires react update as well, which we'll do separately.Tests
Changelog
Documentation
Dark mode