Fix Oban option, split operations in CSV import export test #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
csv-flaky-test-attempt
branch
from
40756b2 to
06be244
Compare
ukutaht
approved these changes
Mar 5, 2025
ruslandoga
reviewed
Mar 10, 2025
| assert {:ok, files} = | ||
| :zip.unzip(to_charlist(Path.join(tmp_dir, "plausible-export.zip")), |
apata
force-pushed
the
csv-flaky-test-attempt
branch
from
06be244 to
3012a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This probably doesn't fix the flakiness with this test suite (which I managed to reproduce locally, see Basecamp card), but it fixes Oban options in the test (https://hexdocs.pm/oban/Oban.html#drain_queue/2-options) and clarifies the private unzip testing function to better show what part of the operation failed.