Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Control Support #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

comeadhra
Copy link

Adding support for Radio Control

@psigen
Copy link
Member

psigen commented Jul 31, 2015

Looks pretty good, I need to do a few minor cleanups and then it should be good to merge 👍

@@ -62,6 +62,8 @@ void Seaking::arm()
{
disable();
delay(500);
disable();
delay(500);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we disable twice here? We could just wait 1s after the first disable, right?

Or is this a typo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a typo. I removed it before, but it must have got back in somehow.

@jjblum
Copy link

jjblum commented Nov 24, 2016

I am going to attempt to use an SBUS based RC receiver. This digital format may solve the vague PWM range issues and provide up to 16 channels on a single RX wire. The receiver and transmitter are a bit more expensive, but I think the system should be improved and will allow control of multiple boats (though only one at a time) from a single transmitter. If it does work out, we'll need to decide if we want to merge this PWM based code or the SBUS version.

There may be a way of creating a more general class so that both can be supported. I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants